Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 469243002: IDL: Prefer to extend IdlTypeBase instead of IdlType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: drop import of IdlType Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_utilities.py
diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py
index f401a0b8339f27da11a5cccb0e81a3d3e0675b45..f78251b033fc44e51e43d9041dfd71f004f892db 100644
--- a/Source/bindings/scripts/v8_utilities.py
+++ b/Source/bindings/scripts/v8_utilities.py
@@ -28,14 +28,14 @@
"""Functions shared by various parts of the code generator.
-Extends IdlType and IdlUnion type with |enum_validation_expression| property.
+Extends IdlTypeBase type with |enum_validation_expression| property.
Design doc: http://www.chromium.org/developers/design-documents/idl-compiler
"""
import re
-from idl_types import IdlType, IdlUnionType
+from idl_types import IdlTypeBase
import idl_types
from v8_globals import includes
import v8_types
@@ -122,7 +122,7 @@ def enum_validation_expression(idl_type):
return None
return ' || '.join(['string == "%s"' % enum_value
for enum_value in idl_type.enum_values])
-IdlType.enum_validation_expression = property(enum_validation_expression)
+IdlTypeBase.enum_validation_expression = property(enum_validation_expression)
def scoped_name(interface, definition, base_name):
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698