Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 469213002: [turbofan] Introduce WordRor machine operator. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce WordRor machine operator. Move recognition of rotate-right operations to the MachineOperatorReducer, so we don't need to repeat that in the InstructionSelector for every backend. TEST=base-unittests,compiler-unittests,cctests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23121

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -113 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/base/bits.h View 1 chunk +29 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 3 chunks +13 lines, -47 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-node-factory.h View 3 chunks +3 lines, -9 lines 0 comments Download
M src/compiler/machine-operator.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 3 chunks +60 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/base-unittests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M test/base-unittests/base-unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/base-unittests/bits-unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 4 chunks +37 lines, -57 lines 0 comments Download
M test/compiler-unittests/compiler-unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/compiler-unittests/machine-operator-reducer-unittest.cc View 1 chunk +139 lines, -0 lines 0 comments Download
M test/compiler-unittests/node-matchers.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/compiler-unittests/node-matchers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-14 08:46:36 UTC) #1
Jarin
lgtm with one comment - please update the .gn file.
6 years, 4 months ago (2014-08-14 09:06:05 UTC) #2
Benedikt Meurer
Done.
6 years, 4 months ago (2014-08-14 09:07:02 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-14 09:08:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23121 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698