Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 468793004: VM: Improve performance of method recognizer and unify the it with the intrinsifier. (Closed)

Created:
6 years, 4 months ago by Florian Schneider
Modified:
6 years, 4 months ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis, siva
Visibility:
Public.

Description

VM: Improve performance of method recognizer and unify the it with the intrinsifier. The method recognizer is now in a separate file and the intrinsifier uses the same infrastructure. Each function is marked at initialization time, so that recognizing a method is a fast operation (reading a field from the Function object) I cleaned the symbol table from unused symbols since I had to regenerate the binary snapshot in the repository anyway for this change. I had to rename the methods that are duplicated between the recognized method list and the intrinsics list to match the naming convention used by the method recognizer. I left the other intrinsics unchanged for now. They will be renamed in a future CL. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39444

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+707 lines, -849 lines) Patch
M runtime/vm/flow_graph_inliner.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 2 chunks +1 line, -255 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 chunks +1 line, -169 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 3 2 chunks +4 lines, -141 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 2 3 3 chunks +30 lines, -100 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 20 chunks +27 lines, -27 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 2 20 chunks +27 lines, -27 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 21 chunks +27 lines, -27 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 21 chunks +27 lines, -27 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 19 chunks +27 lines, -27 lines 0 comments Download
A runtime/vm/method_recognizer.h View 1 chunk +387 lines, -0 lines 0 comments Download
A runtime/vm/method_recognizer.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 6 chunks +54 lines, -18 lines 0 comments Download
M runtime/vm/object.cc View 5 chunks +10 lines, -4 lines 0 comments Download
M runtime/vm/symbols.h View 7 chunks +0 lines, -26 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/issue14236_test.dart View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Florian Schneider
6 years, 4 months ago (2014-08-20 13:46:24 UTC) #1
srdjan
LGTM. Excellent, always wanted to do that! https://codereview.chromium.org/468793004/diff/60001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/468793004/diff/60001/runtime/vm/object.h#newcode1862 runtime/vm/object.h:1862: bool is_always_inline() ...
6 years, 4 months ago (2014-08-20 17:13:46 UTC) #2
Cutch
Nice clean up. https://codereview.chromium.org/468793004/diff/60001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/468793004/diff/60001/runtime/vm/object.h#newcode1862 runtime/vm/object.h:1862: bool is_always_inline() const { On 2014/08/20 ...
6 years, 4 months ago (2014-08-20 17:17:25 UTC) #3
Florian Schneider
https://codereview.chromium.org/468793004/diff/60001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/468793004/diff/60001/runtime/vm/object.h#newcode1862 runtime/vm/object.h:1862: bool is_always_inline() const { On 2014/08/20 17:13:46, srdjan wrote: ...
6 years, 4 months ago (2014-08-21 09:31:08 UTC) #4
Florian Schneider
6 years, 4 months ago (2014-08-21 10:21:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r39444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698