VM: Improve performance of method recognizer and unify the it with the intrinsifier.

runtime/vm/intrinsifier_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM64.
 #if defined(TARGET_ARCH_ARM64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, enable_type_checks);
 
 #define __ assembler->
 
 
-void Intrinsifier::Array_getLength(Assembler* assembler) {
+void Intrinsifier::ObjectArrayLength(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, Array::length_offset()));
   __ ret();
 }
 
 
-void Intrinsifier::ImmutableList_getLength(Assembler* assembler) {
-  Array_getLength(assembler);
+void Intrinsifier::ImmutableArrayLength(Assembler* assembler) {
+  ObjectArrayLength(assembler);
 }
 
 
-void Intrinsifier::Array_getIndexed(Assembler* assembler) {
+void Intrinsifier::ObjectArrayGetIndexed(Assembler* assembler) {
   Label fall_through;
 
   __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index
   __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array
 
   __ tsti(R0, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not an smi, fall through.
 
   // Range check.
   __ ldr(R6, FieldAddress(R1, Array::length_offset()));
   __ cmp(R0, Operand(R6));
   __ b(&fall_through, CS);
 
   ASSERT(kSmiTagShift == 1);
   // array element at R1 + R0*4 + Array::data_offset - 1
   __ add(R6, R1, Operand(R0, LSL, 2));
   __ ldr(R0, FieldAddress(R6, Array::data_offset()));
   __ ret();
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::ImmutableList_getIndexed(Assembler* assembler) {
-  Array_getIndexed(assembler);
+void Intrinsifier::ImmutableArrayGetIndexed(Assembler* assembler) {
+  ObjectArrayGetIndexed(assembler);
 }
 
 
 static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
   const Library& core_lib = Library::Handle(Library::CoreLibrary());
   const Class& cls = Class::Handle(
       core_lib.LookupClassAllowPrivate(Symbols::_List()));
   ASSERT(!cls.IsNull());
   ASSERT(cls.NumTypeArguments() == 1);
   const intptr_t field_offset = cls.type_arguments_field_offset();
   ASSERT(field_offset != Class::kNoTypeArguments);
   return field_offset;
 }
 
 
 // Intrinsify only for Smi value and index. Non-smi values need a store buffer
 // update. Array length is always a Smi.
-void Intrinsifier::Array_setIndexed(Assembler* assembler) {
+void Intrinsifier::ObjectArraySetIndexed(Assembler* assembler) {
   Label fall_through;
 
   if (FLAG_enable_type_checks) {
     const intptr_t type_args_field_offset =
         ComputeObjectArrayTypeArgumentsOffset();
     // Inline simple tests (Smi, null), fallthrough if not positive.
     Label checked_ok;
     __ ldr(R2, Address(SP, 0 * kWordSize));  // Value.
 
     // Null value is valid for any type.
@@ skipping 42 matching lines @@
                      FieldAddress(R1, Array::data_offset()),
                      R2);
   // Caller is responsible for preserving the value if necessary.
   __ ret();
   __ Bind(&fall_through);
 }
 
 
 // Allocate a GrowableObjectArray using the backing array specified.
 // On stack: type argument (+1), data (+0).
-void Intrinsifier::GrowableList_Allocate(Assembler* assembler) {
+void Intrinsifier::GrowableArray_Allocate(Assembler* assembler) {
   // The newly allocated object is returned in R0.
   const intptr_t kTypeArgumentsOffset = 1 * kWordSize;
   const intptr_t kArrayOffset = 0 * kWordSize;
   Label fall_through;
 
   // Try allocating in new space.
   const Class& cls = Class::Handle(
       Isolate::Current()->object_store()->growable_object_array_class());
   __ TryAllocate(cls, &fall_through, R0, R1, kNoPP);
 
@@ skipping 15 matching lines @@
 
   // Set the length field in the growable array object to 0.
   __ LoadImmediate(R1, 0, kNoPP);
   __ str(R1, FieldAddress(R0, GrowableObjectArray::length_offset()));
   __ ret();  // Returns the newly allocated object in R0.
 
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::GrowableList_getLength(Assembler* assembler) {
+void Intrinsifier::GrowableArrayLength(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, GrowableObjectArray::length_offset()));
   __ ret();
 }
 
 
-void Intrinsifier::GrowableList_getCapacity(Assembler* assembler) {
+void Intrinsifier::GrowableArrayCapacity(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, GrowableObjectArray::data_offset()));
   __ ldr(R0, FieldAddress(R0, Array::length_offset()));
   __ ret();
 }
 
 
-void Intrinsifier::GrowableList_getIndexed(Assembler* assembler) {
+void Intrinsifier::GrowableArrayGetIndexed(Assembler* assembler) {
   Label fall_through;
 
   __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index
   __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array
 
   __ tsti(R0, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not an smi, fall through.
 
   // Range check.
   __ ldr(R6, FieldAddress(R1, GrowableObjectArray::length_offset()));
   __ cmp(R0, Operand(R6));
   __ b(&fall_through, CS);
 
   ASSERT(kSmiTagShift == 1);
   // array element at R6 + R0 * 4 + Array::data_offset - 1
   __ ldr(R6, FieldAddress(R1, GrowableObjectArray::data_offset()));  // Data
   __ add(R6, R6, Operand(R0, LSL, 2));
   __ ldr(R0, FieldAddress(R6, Array::data_offset()));
   __ ret();
   __ Bind(&fall_through);
 }
 
 
 // Set value into growable object array at specified index.
 // On stack: growable array (+2), index (+1), value (+0).
-void Intrinsifier::GrowableList_setIndexed(Assembler* assembler) {
+void Intrinsifier::GrowableArraySetIndexed(Assembler* assembler) {
   if (FLAG_enable_type_checks) {
     return;
   }
   Label fall_through;
   __ ldr(R1, Address(SP, 1 * kWordSize));  // Index.
   __ ldr(R0, Address(SP, 2 * kWordSize));  // GrowableArray.
   __ tsti(R1, kSmiTagMask);
   __ b(&fall_through, NE);  // Non-smi index.
   // Range check using _length field.
   __ ldr(R2, FieldAddress(R0, GrowableObjectArray::length_offset()));
   __ cmp(R1, Operand(R2));
   // Runtime throws exception.
   __ b(&fall_through, CS);
   __ ldr(R0, FieldAddress(R0, GrowableObjectArray::data_offset()));  // data.
   __ ldr(R2, Address(SP, 0 * kWordSize));  // Value.
   // Note that R1 is Smi, i.e, times 2.
   ASSERT(kSmiTagShift == 1);
   __ add(R1, R0, Operand(R1, LSL, 2));
   __ StoreIntoObject(R0,
                      FieldAddress(R1, Array::data_offset()),
                      R2);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
 // Set length of growable object array. The length cannot
 // be greater than the length of the data container.
 // On stack: growable array (+1), length (+0).
-void Intrinsifier::GrowableList_setLength(Assembler* assembler) {
+void Intrinsifier::GrowableArraySetLength(Assembler* assembler) {
   Label fall_through;
   __ ldr(R0, Address(SP, 1 * kWordSize));  // Growable array.
   __ ldr(R1, Address(SP, 0 * kWordSize));  // Length value.
   __ tsti(R1, kSmiTagMask);  // Check for Smi.
   __ b(&fall_through, NE);
   __ str(R1, FieldAddress(R0, GrowableObjectArray::length_offset()));
   __ ret();
   __ Bind(&fall_through);
   // Fall through on non-Smi.
 }
 
 
 // Set data of growable object array.
 // On stack: growable array (+1), data (+0).
-void Intrinsifier::GrowableList_setData(Assembler* assembler) {
+void Intrinsifier::GrowableArraySetData(Assembler* assembler) {
   if (FLAG_enable_type_checks) {
     return;
   }
   Label fall_through;
   __ ldr(R1, Address(SP, 0 * kWordSize));  // Data.
   // Check that data is an ObjectArray.
   __ tsti(R1, kSmiTagMask);
   __ b(&fall_through, EQ);  // Data is Smi.
   __ CompareClassId(R1, kArrayCid, kNoPP);
   __ b(&fall_through, NE);
   __ ldr(R0, Address(SP, 1 * kWordSize));  // Growable array.
   __ StoreIntoObject(R0,
                      FieldAddress(R0, GrowableObjectArray::data_offset()),
                      R1);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
 // Add an element to growable array if it doesn't need to grow, otherwise
 // call into regular code.
 // On stack: growable array (+1), value (+0).
-void Intrinsifier::GrowableList_add(Assembler* assembler) {
+void Intrinsifier::GrowableArray_add(Assembler* assembler) {
   // In checked mode we need to type-check the incoming argument.
   if (FLAG_enable_type_checks) {
     return;
   }
   Label fall_through;
   // R0: Array.
   __ ldr(R0, Address(SP, 1 * kWordSize));
   // R1: length.
   __ ldr(R1, FieldAddress(R0, GrowableObjectArray::length_offset()));
   // R2: data.
@@ skipping 13 matching lines @@
   __ StoreIntoObject(R2,
                      FieldAddress(R1, Array::data_offset()),
                      R0);
   __ LoadObject(R0, Object::null_object(), PP);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
 // Gets the length of a TypedData.
-void Intrinsifier::TypedData_getLength(Assembler* assembler) {
+void Intrinsifier::TypedDataLength(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, TypedData::length_offset()));
   __ ret();
 }
 
 
-void Intrinsifier::Uint8Array_getIndexed(Assembler* assembler) {
+void Intrinsifier::Uint8ArrayGetIndexed(Assembler* assembler) {
   Label fall_through;
   __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
   __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
   __ tsti(R0, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not a smi, fall through.
 
   // Range check.
   __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
   __ cmp(R0, Operand(R6));
   __ b(&fall_through, CS);
 
   // Array element at R1 + R0 + TypedData::data_offset - 1.
   // Untag R0.
   __ add(R1, R1, Operand(R0, LSR, 1));
   __ ldr(R0, FieldAddress(R1, TypedData::data_offset()), kUnsignedByte);
   __ SmiTag(R0);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::ExternalUint8Array_getIndexed(Assembler* assembler) {
+void Intrinsifier::ExternalUint8ArrayGetIndexed(Assembler* assembler) {
   Label fall_through;
 
   __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
   __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
   __ tsti(R0, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not a smi, fall through.
 
   // Range check.
   __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
   __ cmp(R0, Operand(R6));
   __ b(&fall_through, CS);
 
   __ ldr(R1, FieldAddress(R1, ExternalTypedData::data_offset()));
 
   // Untag R0.
   __ add(R1, R1, Operand(R0, LSR, 1));
   __ ldr(R0, Address(R1, 0), kUnsignedByte);
   __ SmiTag(R0);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::Float64Array_getIndexed(Assembler* assembler) {
+void Intrinsifier::Float64ArrayGetIndexed(Assembler* assembler) {
   Label fall_through;
   __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
   __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
   __ tsti(R0, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not a smi, fall through.
 
   // Range check.
   __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
   __ cmp(R0, Operand(R6));
   __ b(&fall_through, CS);
@@ skipping 14 matching lines @@
                  &fall_through,
                  R0,  // Result register.
                  R1,  // Temp register.
                  kNoPP);
   __ StoreDFieldToOffset(V0, R0, Double::value_offset(), kNoPP);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::Float64Array_setIndexed(Assembler* assembler) {
+void Intrinsifier::Float64ArraySetIndexed(Assembler* assembler) {
   Label fall_through;
   __ ldr(R0, Address(SP, + 1 * kWordSize));  // Index.
   __ ldr(R1, Address(SP, + 2 * kWordSize));  // Array.
   __ tsti(R0, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not a smi, fall through.
 
   // Range check.
   __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
   __ cmp(R0, Operand(R6));
   __ b(&fall_through, CS);
@@ skipping 728 matching lines @@
   __ Bind(&is_zero);
   // Check for negative zero by looking at the sign bit.
   __ fmovrd(R1, V0);
   __ Lsr(R1, R1, 63);
   __ tsti(R1, 1);
   __ csel(R0, true_reg, false_reg, NE);  // Sign bit set.
   __ ret();
 }
 
 
-void Intrinsifier::Double_toInt(Assembler* assembler) {
+void Intrinsifier::DoubleToInteger(Assembler* assembler) {
   Label fall_through;
 
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ LoadDFieldFromOffset(V0, R0, Double::value_offset(), kNoPP);
 
   // Explicit NaN check, since ARM gives an FPU exception if you try to
   // convert NaN to an int.
   __ fcmpd(V0, V0);
   __ b(&fall_through, VS);
 
   __ fcvtzds(R0, V0);
   // Overflow is signaled with minint.
   // Check for overflow and that it fits into Smi.
   __ CompareImmediate(R0, 0xC000000000000000, kNoPP);
   __ b(&fall_through, MI);
   __ SmiTag(R0);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::Math_sqrt(Assembler* assembler) {
+void Intrinsifier::MathSqrt(Assembler* assembler) {
   Label fall_through, is_smi, double_op;
   TestLastArgumentIsDouble(assembler, &is_smi, &fall_through);
   // Argument is double and is in R0.
   __ LoadDFieldFromOffset(V1, R0, Double::value_offset(), kNoPP);
   __ Bind(&double_op);
   __ fsqrtd(V0, V1);
   const Class& double_class = Class::Handle(
       Isolate::Current()->object_store()->double_class());
   __ TryAllocate(double_class, &fall_through, R0, R1, kNoPP);
   __ StoreDFieldToOffset(V0, R0, Double::value_offset(), kNoPP);
@@ skipping 36 matching lines @@
   __ LoadFromOffset(R2, R1, disp, kNoPP);
   __ Lsr(R3, R2, 32);
   __ andi(R2, R2, 0xffffffff);
   __ mul(R2, R0, R2);
   __ add(R2, R2, Operand(R3));
   __ StoreToOffset(R2, R1, disp, kNoPP);
   __ ret();
 }
 
 
-void Intrinsifier::Object_equal(Assembler* assembler) {
+void Intrinsifier::ObjectEquals(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R1, Address(SP, 1 * kWordSize));
   __ cmp(R0, Operand(R1));
   __ LoadObject(R0, Bool::False(), PP);
   __ LoadObject(TMP, Bool::True(), PP);
   __ csel(R0, TMP, R0, EQ);
   __ ret();
 }
 
 
 void Intrinsifier::String_getHashCode(Assembler* assembler) {
   Label fall_through;
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, String::hash_offset()));
   __ CompareRegisters(R0, ZR);
   __ b(&fall_through, EQ);
   __ ret();
   // Hash not yet computed.
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::String_getLength(Assembler* assembler) {
+void Intrinsifier::StringBaseLength(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, String::length_offset()));
   __ ret();
 }
 
 
-void Intrinsifier::String_codeUnitAt(Assembler* assembler) {
+void Intrinsifier::StringBaseCodeUnitAt(Assembler* assembler) {
   Label fall_through, try_two_byte_string;
 
   __ ldr(R1, Address(SP, 0 * kWordSize));  // Index.
   __ ldr(R0, Address(SP, 1 * kWordSize));  // String.
   __ tsti(R1, kSmiTagMask);
   __ b(&fall_through, NE);  // Index is not a Smi.
   // Range check.
   __ ldr(R2, FieldAddress(R0, String::length_offset()));
   __ cmp(R1, Operand(R2));
   __ b(&fall_through, CS);  // Runtime throws exception.
@@ skipping 11 matching lines @@
   ASSERT(kSmiTagShift == 1);
   __ AddImmediate(R0, R0, TwoByteString::data_offset() - kHeapObjectTag, kNoPP);
   __ ldr(R0, Address(R0, R1), kUnsignedHalfword);
   __ SmiTag(R0);
   __ ret();
 
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::String_getIsEmpty(Assembler* assembler) {
+void Intrinsifier::StringBaseIsEmpty(Assembler* assembler) {
   __ ldr(R0, Address(SP, 0 * kWordSize));
   __ ldr(R0, FieldAddress(R0, String::length_offset()));
   __ cmp(R0, Operand(Smi::RawValue(0)));
   __ LoadObject(R0, Bool::True(), PP);
   __ LoadObject(TMP, Bool::False(), PP);
   __ csel(R0, TMP, R0, NE);
   __ ret();
 }
 
 
@@ skipping 187 matching lines @@
   __ str(R1, FieldAddress(R7, OneByteString::data_offset()), kUnsignedByte);
   __ AddImmediate(R7, R7, 1, kNoPP);
   __ b(&loop, GT);
 
   __ Bind(&done);
   __ ret();
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::OneByteString_setAt(Assembler* assembler) {
+void Intrinsifier::OneByteStringSetAt(Assembler* assembler) {
   __ ldr(R2, Address(SP, 0 * kWordSize));  // Value.
   __ ldr(R1, Address(SP, 1 * kWordSize));  // Index.
   __ ldr(R0, Address(SP, 2 * kWordSize));  // OneByteString.
   __ SmiUntag(R1);
   __ SmiUntag(R2);
   __ AddImmediate(R3, R0, OneByteString::data_offset() - kHeapObjectTag, kNoPP);
   __ str(R2, Address(R3, R1), kUnsignedByte);
   __ ret();
 }
 
@@ skipping 120 matching lines @@
   Isolate* isolate = Isolate::Current();
   __ LoadImmediate(R1, reinterpret_cast<uword>(isolate), kNoPP);
   // Set return value to Isolate::current_tag_.
   __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
   __ ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM64