Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 468543002: Revert refactoring of CSSProperty .in files (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
Reviewers:
Timothy Loh
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, rune+blink, sergeyv+blink_chromium.org, shans, Steve Block, Timothy Loh, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert refactoring of CSSProperty .in files This reverts https://src.chromium.org/viewvc/blink?revision=180034&view=revision and its two followups: https://src.chromium.org/viewvc/blink?revision=180039&view=revision https://src.chromium.org/viewvc/blink?revision=180051&view=revision r180034 caused lots of browser_test failures in debug mode, all with the following ASSERT: ASSERTION FAILED: RuntimeCSSEnabled::isCSSPropertyEnabled(propertyID) || isInternalProperty(propertyID) ../../third_party/WebKit/Source/core/css/StylePropertySet.cpp(558) : int blink::MutableStylePropertySet::findPropertyIndex(blink::CSSPropertyID) const Most of the failures I saw were in the PrintPreviewWebUITest suite. The followup patches had to be reverted to make the revert of r180034 clean. BUG=396992 TBR=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1306 lines, -411 lines) Patch
M Source/build/scripts/css_properties.py View 3 chunks +1 line, -14 lines 0 comments Download
D Source/build/scripts/make_css_property_metadata.py View 1 chunk +0 lines, -29 lines 0 comments Download
M Source/build/scripts/make_css_property_names.py View 3 chunks +44 lines, -18 lines 0 comments Download
D Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 chunk +0 lines, -26 lines 0 comments Download
M Source/core/BUILD.gn View 3 chunks +5 lines, -15 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 5 chunks +118 lines, -4 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/core_generated.gyp View 3 chunks +9 lines, -20 lines 0 comments Download
M Source/core/css/CSSProperties.in View 9 chunks +178 lines, -229 lines 0 comments Download
M Source/core/css/CSSProperty.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +415 lines, -0 lines 0 comments Download
D Source/core/css/CSSPropertyMetadata.h View 1 chunk +0 lines, -20 lines 0 comments Download
A Source/core/css/CSSPropertyNames.in View 1 chunk +421 lines, -0 lines 0 comments Download
A Source/core/css/SVGCSSPropertyNames.in View 1 chunk +51 lines, -0 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/scripts/generate_supported_css.py View 1 chunk +45 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
Committed patchset #1 manually as 180090 (presubmit successful).
6 years, 4 months ago (2014-08-12 18:16:34 UTC) #1
adamk
Reverted in https://src.chromium.org/viewvc/blink?revision=180090&view=revision for assertion failures in print preview browser_tests
6 years, 4 months ago (2014-08-12 18:17:17 UTC) #2
adamk
6 years, 4 months ago (2014-08-12 18:17:42 UTC) #3
Message was sent while issue was closed. 
On 2014/08/12 at 18:17:17, adamk wrote:
> Reverted in
https://src.chromium.org/viewvc/blink?revision=180090&view=revision for
assertion failures in print preview browser_tests

Er, ignore that :)

Powered by Google App Engine
This is Rietveld 408576698