Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Side by Side Diff: Source/build/scripts/make_css_property_names.py

Issue 468543002: Revert refactoring of CSSProperty .in files (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 import os.path
4 import re
3 import subprocess 5 import subprocess
4 import sys 6 import sys
5 7
6 import css_properties 8 from in_file import InFile
7 import in_generator 9 import in_generator
8 import license 10 import license
9 11
10 12
11 HEADER_TEMPLATE = """ 13 HEADER_TEMPLATE = """
12 %(license)s 14 %(license)s
13 15
14 #ifndef %(class_name)s_h 16 #ifndef %(class_name)s_h
15 #define %(class_name)s_h 17 #define %(class_name)s_h
16 18
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 return true; 171 return true;
170 default: 172 default:
171 return false; 173 return false;
172 } 174 }
173 } 175 }
174 176
175 } // namespace blink 177 } // namespace blink
176 """ 178 """
177 179
178 180
179 class CSSPropertyNamesWriter(css_properties.CSSProperties): 181 class CSSPropertiesWriter(in_generator.Writer):
180 class_name = "CSSPropertyNames" 182 class_name = "CSSPropertyNames"
183 defaults = {
184 'alias_for': None,
185 'is_internal': False,
186 }
181 187
182 def __init__(self, in_file_path): 188 def __init__(self, file_paths):
183 super(CSSPropertyNamesWriter, self).__init__(in_file_path) 189 in_generator.Writer.__init__(self, file_paths)
184 self._outputs = {(self.class_name + ".h"): self.generate_header, 190 self._outputs = {(self.class_name + ".h"): self.generate_header,
185 (self.class_name + ".cpp"): self.generate_implementatio n, 191 (self.class_name + ".cpp"): self.generate_implementatio n,
186 } 192 }
187 193
194 self._aliases = filter(lambda property: property['alias_for'], self.in_f ile.name_dictionaries)
195 for offset, property in enumerate(self._aliases):
196 # Aliases use the enum_name that they are an alias for.
197 property['enum_name'] = self._enum_name_from_property_name(property[ 'alias_for'])
198 # Aliases do not get an enum_value.
199
200 self._properties = filter(lambda property: not property['alias_for'], se lf.in_file.name_dictionaries)
201 if len(self._properties) > 1024:
202 print "ERROR : There is more than 1024 CSS Properties, you need to u pdate CSSProperty.h/StylePropertyMetadata m_propertyID accordingly."
203 exit(1)
204 self._first_property_id = 1 # We start after CSSPropertyInvalid.
205 property_id = self._first_property_id
206 for offset, property in enumerate(self._properties):
207 property['enum_name'] = self._enum_name_from_property_name(property[ 'name'])
208 property['enum_value'] = self._first_property_id + offset
209 if property['name'].startswith('-internal-'):
210 property['is_internal'] = True
211
212 def _enum_name_from_property_name(self, property_name):
213 return "CSSProperty" + re.sub(r'(^[^-])|-(.)', lambda match: (match.grou p(1) or match.group(2)).upper(), property_name)
214
188 def _enum_declaration(self, property): 215 def _enum_declaration(self, property):
189 return " %(property_id)s = %(enum_value)s," % property 216 return " %(enum_name)s = %(enum_value)s," % property
190 217
191 def generate_header(self): 218 def generate_header(self):
192 return HEADER_TEMPLATE % { 219 return HEADER_TEMPLATE % {
193 'license': license.license_for_generated_cpp(), 220 'license': license.license_for_generated_cpp(),
194 'class_name': self.class_name, 221 'class_name': self.class_name,
195 'property_enums': "\n".join(map(self._enum_declaration, self._proper ties_list)), 222 'property_enums': "\n".join(map(self._enum_declaration, self._proper ties)),
196 'first_property_id': self._first_enum_value, 223 'first_property_id': self._first_property_id,
197 'properties_count': len(self._properties), 224 'properties_count': len(self._properties),
198 'last_property_id': self._first_enum_value + len(self._properties) - 1, 225 'last_property_id': self._first_property_id + len(self._properties) - 1,
199 'max_name_length': max(map(len, self._properties)), 226 'max_name_length': reduce(max, map(len, map(lambda property: propert y['name'], self._properties))),
200 } 227 }
201 228
229 def _case_properties(self, property):
230 return "case %(enum_name)s:" % property
231
202 def generate_implementation(self): 232 def generate_implementation(self):
203 property_offsets = [] 233 property_offsets = []
204 current_offset = 0 234 current_offset = 0
205 for property in self._properties_list: 235 for property in self._properties:
206 property_offsets.append(current_offset) 236 property_offsets.append(current_offset)
207 current_offset += len(property["name"]) + 1 237 current_offset += len(property["name"]) + 1
208 238
209 css_name_and_enum_pairs = [(property['name'], property_id) for property_ id, property in self._properties.items()]
210 for name, aliased_name in self._aliases.items():
211 css_name_and_enum_pairs.append((name, css_properties.css_name_to_enu m(aliased_name)))
212
213 gperf_input = GPERF_TEMPLATE % { 239 gperf_input = GPERF_TEMPLATE % {
214 'license': license.license_for_generated_cpp(), 240 'license': license.license_for_generated_cpp(),
215 'class_name': self.class_name, 241 'class_name': self.class_name,
216 'property_name_strings': '\n'.join(map(lambda property: ' "%(name )s\\0"' % property, self._properties_list)), 242 'property_name_strings': '\n'.join(map(lambda property: ' "%(name )s\\0"' % property, self._properties)),
217 'property_name_offsets': '\n'.join(map(lambda offset: ' %d,' % of fset, property_offsets)), 243 'property_name_offsets': '\n'.join(map(lambda offset: ' %d,' % of fset, property_offsets)),
218 'property_to_enum_map': '\n'.join(map(lambda property: '%s, %s' % pr operty, css_name_and_enum_pairs)), 244 'property_to_enum_map': '\n'.join(map(lambda property: '%(name)s, %( enum_name)s' % property, self._properties + self._aliases)),
219 'internal_properties': '\n'.join("case %s:" % property_id for proper ty_id, property in self._properties.items() if property['is_internal']), 245 'internal_properties': '\n'.join(map(self._case_properties, filter(l ambda property: property['is_internal'], self._properties))),
220 } 246 }
221 # FIXME: If we could depend on Python 2.7, we would use subprocess.check _output 247 # FIXME: If we could depend on Python 2.7, we would use subprocess.check _output
222 gperf_args = [self.gperf_path, '--key-positions=*', '-P', '-n'] 248 gperf_args = [self.gperf_path, '--key-positions=*', '-P', '-n']
223 gperf_args.extend(['-m', '50']) # Pick best of 50 attempts. 249 gperf_args.extend(['-m', '50']) # Pick best of 50 attempts.
224 gperf_args.append('-D') # Allow duplicate hashes -> More compact code. 250 gperf_args.append('-D') # Allow duplicate hashes -> More compact code.
225 gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE, stdout=subpr ocess.PIPE, universal_newlines=True) 251 gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE, stdout=subpr ocess.PIPE, universal_newlines=True)
226 return gperf.communicate(gperf_input)[0] 252 return gperf.communicate(gperf_input)[0]
227 253
228 254
229 if __name__ == "__main__": 255 if __name__ == "__main__":
230 in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv) 256 in_generator.Maker(CSSPropertiesWriter).main(sys.argv)
OLDNEW
« no previous file with comments | « Source/build/scripts/make_css_property_metadata.py ('k') | Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698