Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/core/animation/css/CSSAnimations.h

Issue 468543002: Revert refactoring of CSSProperty .in files (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 WTF_MAKE_NONCOPYABLE(CSSAnimations); 163 WTF_MAKE_NONCOPYABLE(CSSAnimations);
164 DISALLOW_ALLOCATION(); 164 DISALLOW_ALLOCATION();
165 public: 165 public:
166 CSSAnimations(); 166 CSSAnimations();
167 167
168 // FIXME: This method is only used here and in the legacy animations 168 // FIXME: This method is only used here and in the legacy animations
169 // implementation. It should be made private or file-scope when the legacy 169 // implementation. It should be made private or file-scope when the legacy
170 // engine is removed. 170 // engine is removed.
171 static const StyleRuleKeyframes* matchScopedKeyframesRule(StyleResolver*, co nst Element*, const StringImpl*); 171 static const StyleRuleKeyframes* matchScopedKeyframesRule(StyleResolver*, co nst Element*, const StringImpl*);
172 172
173 static bool isAnimatableProperty(CSSPropertyID);
173 static const StylePropertyShorthand& animatableProperties(); 174 static const StylePropertyShorthand& animatableProperties();
174 static bool isAllowedAnimation(CSSPropertyID); 175 static bool isAllowedAnimation(CSSPropertyID);
175 // FIXME: We should change the Element* to a const Element* 176 // FIXME: We should change the Element* to a const Element*
176 static PassOwnPtrWillBeRawPtr<CSSAnimationUpdate> calculateUpdate(Element*, const Element& parentElement, const RenderStyle&, RenderStyle* parentStyle, Styl eResolver*); 177 static PassOwnPtrWillBeRawPtr<CSSAnimationUpdate> calculateUpdate(Element*, const Element& parentElement, const RenderStyle&, RenderStyle* parentStyle, Styl eResolver*);
177 178
178 void setPendingUpdate(PassOwnPtrWillBeRawPtr<CSSAnimationUpdate> update) { m _pendingUpdate = update; } 179 void setPendingUpdate(PassOwnPtrWillBeRawPtr<CSSAnimationUpdate> update) { m _pendingUpdate = update; }
179 void maybeApplyPendingUpdate(Element*); 180 void maybeApplyPendingUpdate(Element*);
180 bool isEmpty() const { return m_animations.isEmpty() && m_transitions.isEmpt y() && !m_pendingUpdate; } 181 bool isEmpty() const { return m_animations.isEmpty() && m_transitions.isEmpt y() && !m_pendingUpdate; }
181 void cancel(); 182 void cancel();
182 183
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 const CSSPropertyID m_property; 252 const CSSPropertyID m_property;
252 AnimationNode::Phase m_previousPhase; 253 AnimationNode::Phase m_previousPhase;
253 }; 254 };
254 }; 255 };
255 256
256 } // namespace blink 257 } // namespace blink
257 258
258 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::CSSAnimationUpdate::NewAnimation); 259 WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS(blink::CSSAnimationUpdate::NewAnimation);
259 260
260 #endif 261 #endif
OLDNEW
« no previous file with comments | « Source/core/animation/css/CSSAnimatableValueFactory.cpp ('k') | Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698