Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 468473002: AudioContext::removeAutomaticPullNode() should be called in AudioNode::dispose() (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, tkent
CC:
blink-reviews, Raymond Toy
Project:
blink
Visibility:
Public.

Description

AudioContext::removeAutomaticPullNode() should be called in AudioNode::dispose() Currently, in oilpan builds, removeAutomaticPullNode() is called in AudioNode::dispose(). In non-oilpan builds, removeAutomaticPullNode() is called in AudioContext::markForDeletion(). We don't want to have different call paths between oilpan builds and non-oilpan builds. Given that removeAutomaticPullNode() should be called when the AudioNode is destructed (but before the associated AudioContext is gone), removeAutomaticPullNode() should always be called in AudioNode::dispose(). BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M Source/modules/webaudio/AudioContext.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-12 13:24:18 UTC) #1
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 02:25:32 UTC) #2
tkent
lgtm
6 years, 4 months ago (2014-08-14 02:25:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/468473002/1
6 years, 4 months ago (2014-08-14 02:26:39 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 04:17:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180232

Powered by Google App Engine
This is Rietveld 408576698