Source/modules/webaudio/AudioNode.cpp - Issue 468473002: AudioContext::removeAutomaticPullNode() should be called in AudioNode::dispose()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioNode.cpp

Issue 468473002: AudioContext::removeAutomaticPullNode() should be called in AudioNode::dispose() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/AudioNode.cpp

diff --git a/Source/modules/webaudio/AudioNode.cpp b/Source/modules/webaudio/AudioNode.cpp

index f325bee4b7fe0be99a585a1d78a51af7652f371f..4e8511e310606fb7885e53e58de7e0c505a6a5b8 100644

--- a/Source/modules/webaudio/AudioNode.cpp

+++ b/Source/modules/webaudio/AudioNode.cpp

@@ -108,8 +108,9 @@ void AudioNode::dispose()

{

ASSERT(isMainThread());

ASSERT(context()->isGraphOwner());

-#if ENABLE(OILPAN)

context()->removeAutomaticPullNode(this);

+#if ENABLE(OILPAN)

for (unsigned i = 0; i < m_outputs.size(); ++i)

output(i)->disconnectAll();

#endif

« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | no next file » | no next file with comments »