Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: Source/modules/webaudio/AudioNode.cpp

Issue 468473002: AudioContext::removeAutomaticPullNode() should be called in AudioNode::dispose() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 void AudioNode::uninitialize() 102 void AudioNode::uninitialize()
103 { 103 {
104 m_isInitialized = false; 104 m_isInitialized = false;
105 } 105 }
106 106
107 void AudioNode::dispose() 107 void AudioNode::dispose()
108 { 108 {
109 ASSERT(isMainThread()); 109 ASSERT(isMainThread());
110 ASSERT(context()->isGraphOwner()); 110 ASSERT(context()->isGraphOwner());
111
112 context()->removeAutomaticPullNode(this);
111 #if ENABLE(OILPAN) 113 #if ENABLE(OILPAN)
112 context()->removeAutomaticPullNode(this);
113 for (unsigned i = 0; i < m_outputs.size(); ++i) 114 for (unsigned i = 0; i < m_outputs.size(); ++i)
114 output(i)->disconnectAll(); 115 output(i)->disconnectAll();
115 #endif 116 #endif
116 context()->unmarkDirtyNode(*this); 117 context()->unmarkDirtyNode(*this);
117 #if ENABLE(ASSERT) 118 #if ENABLE(ASSERT)
118 m_didCallDispose = true; 119 m_didCallDispose = true;
119 #endif 120 #endif
120 } 121 }
121 122
122 String AudioNode::nodeTypeName() const 123 String AudioNode::nodeTypeName() const
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 { 648 {
648 visitor->trace(m_context); 649 visitor->trace(m_context);
649 visitor->trace(m_inputs); 650 visitor->trace(m_inputs);
650 visitor->trace(m_outputs); 651 visitor->trace(m_outputs);
651 EventTargetWithInlineData::trace(visitor); 652 EventTargetWithInlineData::trace(visitor);
652 } 653 }
653 654
654 } // namespace blink 655 } // namespace blink
655 656
656 #endif // ENABLE(WEB_AUDIO) 657 #endif // ENABLE(WEB_AUDIO)
OLDNEW
« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698