Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 468253002: Move file_util to base/files/ directory. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, wfh+watch_chromium.org, gavinp+memory_chromium.org, dsinclair+watch_chromium.org, tfarina, erikwright+watch_chromium.org, jshin+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move file_util to base/files/ directory. This updates the includes in base but leaves a forwarding header for the rest of the project for now. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289360

Patch Set 1 #

Patch Set 2 : Forgot to add forwarding header to patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -5267 lines) Patch
M base/BUILD.gn View 4 chunks +9 lines, -9 lines 0 comments Download
M base/android/path_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 5 chunks +11 lines, -11 lines 0 comments Download
M base/base_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/cpu.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/proc_maps_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/event_recorder_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/file_util.h View 1 1 chunk +3 lines, -436 lines 0 comments Download
D base/file_util.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D base/file_util_android.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D base/file_util_linux.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D base/file_util_mac.mm View 1 chunk +0 lines, -52 lines 0 comments Download
D base/file_util_posix.cc View 1 chunk +0 lines, -912 lines 0 comments Download
D base/file_util_unittest.cc View 1 chunk +0 lines, -2596 lines 0 comments Download
D base/file_util_win.cc View 1 chunk +0 lines, -810 lines 0 comments Download
M base/files/file_enumerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_fsevents.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_kqueue.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/files/file_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + base/files/file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/files/file_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/files/file_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/files/file_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + base/files/file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/files/file_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/files/file_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/memory_mapped_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/scoped_temp_dir.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/scoped_temp_dir_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/build_utf8_validator_tables.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_file_value_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_serializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/linux_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/mac_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_ashmem_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/xdg_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/os_compat_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/path_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/path_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/posix/unix_domain_socket_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/internal_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/launch_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/memory_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_handle_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_iterator_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_metrics_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/rand_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/security_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sync_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/gtest_xml_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_results_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/perf_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/shortcut.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/shortcut_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
This is just search-and-replace.
6 years, 4 months ago (2014-08-13 17:10:52 UTC) #1
yzshen1
lgtm
6 years, 4 months ago (2014-08-13 17:53:26 UTC) #2
brettw
Committed patchset #2 manually as 289360 (presubmit successful).
6 years, 4 months ago (2014-08-13 20:22:22 UTC) #3
daskalov3
5 years, 10 months ago (2015-02-18 13:39:03 UTC) #4
Message was sent while issue was closed. 
On 2014/08/13 20:22:22, brettw wrote:
> Committed patchset #2 manually as 289360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698