Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: base/os_compat_android_unittest.cc

Issue 468253002: Move file_util to base/files/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to add forwarding header to patch Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/nix/xdg_util.cc ('k') | base/path_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/os_compat_android.h" 5 #include "base/os_compat_android.h"
6 6
7 #include "base/file_util.h" 7 #include "base/files/file_util.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 typedef testing::Test OsCompatAndroidTest; 12 typedef testing::Test OsCompatAndroidTest;
13 13
14 // Keep this Unittest DISABLED_ , because it actually creates a directory in the 14 // Keep this Unittest DISABLED_ , because it actually creates a directory in the
15 // device and it may be source of flakyness. For any changes in the mkdtemp 15 // device and it may be source of flakyness. For any changes in the mkdtemp
16 // function, you should run this unittest in your local machine to check if it 16 // function, you should run this unittest in your local machine to check if it
17 // passes. 17 // passes.
(...skipping 14 matching lines...) Expand all
32 32
33 // Successfully create a tmp dir. 33 // Successfully create a tmp dir.
34 FilePath sub_dir2 = tmp_dir.Append("XXXXXX"); 34 FilePath sub_dir2 = tmp_dir.Append("XXXXXX");
35 std::string sub_dir2_string = sub_dir2.value(); 35 std::string sub_dir2_string = sub_dir2.value();
36 // this should be OK since mkdtemp just replaces characters in place 36 // this should be OK since mkdtemp just replaces characters in place
37 char* buffer2 = const_cast<char*>(sub_dir2_string.c_str()); 37 char* buffer2 = const_cast<char*>(sub_dir2_string.c_str());
38 EXPECT_TRUE(mkdtemp(buffer2) != NULL); 38 EXPECT_TRUE(mkdtemp(buffer2) != NULL);
39 } 39 }
40 40
41 } // namespace base 41 } // namespace base
OLDNEW
« no previous file with comments | « base/nix/xdg_util.cc ('k') | base/path_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698