Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 467863002: Modify PnaclHeaderTest to run w/ an empty PNaCl component dir. (Closed)

Created:
6 years, 4 months ago by jvoung (off chromium)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Project:
chromium
Visibility:
Public.

Description

Modify PnaclHeaderTest to run w/ an empty PNaCl component dir. This helps check that the pexe fetch is able to happen before the component files are accessed. Otherwise, if the component files are accessed before the pexe fetch, then it will error out early, and the PNaCl on-demand installation will not happen. Followup to Justin's fix: https://codereview.chromium.org/453073002 I tested that without Justin's fix, this patch will make the test catch the error. BUG=401755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289182

Patch Set 1 #

Patch Set 2 : clarify comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/test/nacl/pnacl_header_test.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvoung (off chromium)
6 years, 4 months ago (2014-08-12 20:51:54 UTC) #1
teravest
lgtm Awesome, thanks.
6 years, 4 months ago (2014-08-12 20:55:40 UTC) #2
Nick Bray (chromium)
OWNERs LGTM without fully understanding it, but it sounds like some of the stuff in ...
6 years, 4 months ago (2014-08-12 22:28:57 UTC) #3
jvoung (off chromium)
On 2014/08/12 22:28:57, Nick Bray (chromium) wrote: > OWNERs LGTM without fully understanding it, but ...
6 years, 4 months ago (2014-08-12 22:52:19 UTC) #4
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 4 months ago (2014-08-12 23:09:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/467863002/20001
6 years, 4 months ago (2014-08-12 23:52:35 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 03:24:19 UTC) #7
Message was sent while issue was closed.
Change committed as 289182

Powered by Google App Engine
This is Rietveld 408576698