Issue 453073002: Fix PNaCl on Demand load faliures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453073002: Fix PNaCl on Demand load faliures. (Closed)

Created:
6 years, 4 months ago by teravest

Modified:
6 years, 4 months ago

Reviewers:
dmichael (off chromium), Derek Schuff

CC:
chromium-reviews, Derek Schuff

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix PNaCl on Demand load faliures. r284961 broke PNaCl on-demand by loading resources retrieved by component_uploader before sending a request to download a user pexe. This change fixes the breakage by only loading resources after we've determined that that there is no cached translated nexe. BUG=401755 R=dmichael@chromium.org, dschuff@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288426

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment for dmichael #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -23 lines)			Patch
	M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	1	2 chunks	+26 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm https://codereview.chromium.org/453073002/diff/1/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right): https://codereview.chromium.org/453073002/diff/1/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc#newcode313 ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:313: // The component updater's resource throttles + OnDemand ...

6 years, 4 months ago (2014-08-08 20:51:34 UTC) #3

teravest

6 years, 4 months ago (2014-08-08 20:56:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 288426 (presubmit successful).

Expand Messages | Collapse Messages