Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7648)

Unified Diff: chrome/test/nacl/pnacl_header_test.cc

Issue 467863002: Modify PnaclHeaderTest to run w/ an empty PNaCl component dir. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clarify comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/pnacl_header_test.cc
diff --git a/chrome/test/nacl/pnacl_header_test.cc b/chrome/test/nacl/pnacl_header_test.cc
index 0ebb121139d0891eda45e46152d582bc802d1ad7..e4922aa5867f96e9a8a3a069aee37c589b11546e 100644
--- a/chrome/test/nacl/pnacl_header_test.cc
+++ b/chrome/test/nacl/pnacl_header_test.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/path_service.h"
+#include "base/test/scoped_path_override.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_paths.h"
@@ -45,6 +46,16 @@ void PnaclHeaderTest::RunLoadTest(const std::string& url,
content::JavascriptTestObserver observer(
browser()->tab_strip_model()->GetActiveWebContents(),
&handler);
+
+ // Make sure this is able to do a pexe fetch, even without access
+ // to the PNaCl component files (make DIR_PNACL_COMPONENT empty).
+ // The pexe fetch that is done with special headers must be able to
+ // start before the component files are on disk. This is because it
+ // is the pexe fetch that helps trigger an on-demand installation
+ // which installs the files to disk (if that hasn't already happened
+ // in the background).
+ base::ScopedPathOverride component_dir(chrome::DIR_PNACL_COMPONENT);
+
ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(url));
// Wait until the NMF and pexe are also loaded, not just the HTML.
// Do this by waiting till the LoadTestMessageHandler responds.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698