Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: gm/rebaseline_server/static/live-view.html

Issue 467843002: rebaseline_server: only show Pending Approval tab if expectations vs actuals (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add link to raw JSON Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/static/live-loader.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/static/live-view.html
diff --git a/gm/rebaseline_server/static/live-view.html b/gm/rebaseline_server/static/live-view.html
index cb503784f7e9ab3f7d3409a4ed133733500927ea..28a2bcd17cac7f3eee5a36fb713158b4754d54ab 100644
--- a/gm/rebaseline_server/static/live-view.html
+++ b/gm/rebaseline_server/static/live-view.html
@@ -41,15 +41,10 @@
which records are displayed.
</div>
- <div class="warning-div"
- ng-show="header[constants.KEY__HEADER__IS_EDITABLE] && header[constants.KEY__HEADER__IS_EXPORTED]">
- WARNING! These results are editable and exported, so any user
- who can connect to this server over the network can modify them.
- </div>
-
<div ng-show="header[constants.KEY__HEADER__TIME_UPDATED]">
setA: "{{setASection}}" within {{setADir}}<br>
setB: "{{setBSection}}" within {{setBDir}}<br>
+ <a href="{{liveQueryUrl}}">latest raw JSON diffs between these two sets</a><br>
These results current as of
{{localTimeString(header[constants.KEY__HEADER__TIME_UPDATED])}}
</div>
@@ -169,10 +164,13 @@
<!-- Submission UI that we only show in the Pending Approval tab. -->
<div ng-show="'Pending Approval' == viewingTab">
+ <div style="font-size:20px">
+ TODO(epoger): Rebaselining SKP results does not work yet.
+ </div>
<div style="display:inline-block">
<button style="font-size:20px"
ng-click="submitApprovals(filteredImagePairs)"
- ng-disabled="submitPending || (filteredImagePairs.length == 0)">
+ ng-disabled="true || submitPending || (filteredImagePairs.length == 0)">
Update these {{filteredImagePairs.length}} expectations on the server
</button>
</div>
« no previous file with comments | « gm/rebaseline_server/static/live-loader.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698