Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: gm/rebaseline_server/static/live-view.html

Issue 467843002: rebaseline_server: only show Pending Approval tab if expectations vs actuals (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add link to raw JSON Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/rebaseline_server/static/live-loader.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html ng-app="Loader" ng-controller="Loader.Controller"> 3 <html ng-app="Loader" ng-controller="Loader.Controller">
4 4
5 <head> 5 <head>
6 <title ng-bind="windowTitle"></title> 6 <title ng-bind="windowTitle"></title>
7 <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></scr ipt> 7 <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></scr ipt>
8 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.20/angular.js "></script> 8 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.20/angular.js "></script>
9 <script src="constants.js"></script> 9 <script src="constants.js"></script>
10 <script src="live-loader.js"></script> 10 <script src="live-loader.js"></script>
(...skipping 23 matching lines...) Expand all
34 <div ng-show="readyToDisplay"> 34 <div ng-show="readyToDisplay">
35 35
36 <div class="warning-div" 36 <div class="warning-div"
37 ng-show="urlSchemaVersionLoaded != constants.URL_VALUE__SCHEMA_VERSION_ _CURRENT"> 37 ng-show="urlSchemaVersionLoaded != constants.URL_VALUE__SCHEMA_VERSION_ _CURRENT">
38 WARNING! The URL you loaded used schema version {{urlSchemaVersionLoaded} }, rather than 38 WARNING! The URL you loaded used schema version {{urlSchemaVersionLoaded} }, rather than
39 the most recent version {{constants.URL_VALUE__SCHEMA_VERSION__CURRENT}}. It has been 39 the most recent version {{constants.URL_VALUE__SCHEMA_VERSION__CURRENT}}. It has been
40 converted to the most recent version on a best-effort basis; you may wish to double-check 40 converted to the most recent version on a best-effort basis; you may wish to double-check
41 which records are displayed. 41 which records are displayed.
42 </div> 42 </div>
43 43
44 <div class="warning-div"
45 ng-show="header[constants.KEY__HEADER__IS_EDITABLE] && header[constants .KEY__HEADER__IS_EXPORTED]">
46 WARNING! These results are editable and exported, so any user
47 who can connect to this server over the network can modify them.
48 </div>
49
50 <div ng-show="header[constants.KEY__HEADER__TIME_UPDATED]"> 44 <div ng-show="header[constants.KEY__HEADER__TIME_UPDATED]">
51 setA: "{{setASection}}" within {{setADir}}<br> 45 setA: "{{setASection}}" within {{setADir}}<br>
52 setB: "{{setBSection}}" within {{setBDir}}<br> 46 setB: "{{setBSection}}" within {{setBDir}}<br>
47 <a href="{{liveQueryUrl}}">latest raw JSON diffs between these two sets</a ><br>
53 These results current as of 48 These results current as of
54 {{localTimeString(header[constants.KEY__HEADER__TIME_UPDATED])}} 49 {{localTimeString(header[constants.KEY__HEADER__TIME_UPDATED])}}
55 </div> 50 </div>
56 51
57 <div class="tab-wrapper"><!-- tabs --> 52 <div class="tab-wrapper"><!-- tabs -->
58 <div class="tab-spacer" ng-repeat="tab in tabs"> 53 <div class="tab-spacer" ng-repeat="tab in tabs">
59 <div class="tab tab-{{tab == viewingTab}}" 54 <div class="tab tab-{{tab == viewingTab}}"
60 ng-click="setViewingTab(tab)"> 55 ng-click="setViewingTab(tab)">
61 &nbsp;{{tab}} ({{numResultsPerTab[tab]}})&nbsp; 56 &nbsp;{{tab}} ({{numResultsPerTab[tab]}})&nbsp;
62 </div> 57 </div>
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 </button> 157 </button>
163 </td></tr> 158 </td></tr>
164 </tr></table></td> 159 </tr></table></td>
165 </tr> 160 </tr>
166 </table> 161 </table>
167 162
168 <p> 163 <p>
169 164
170 <!-- Submission UI that we only show in the Pending Approval tab. --> 165 <!-- Submission UI that we only show in the Pending Approval tab. -->
171 <div ng-show="'Pending Approval' == viewingTab"> 166 <div ng-show="'Pending Approval' == viewingTab">
167 <div style="font-size:20px">
168 TODO(epoger): Rebaselining SKP results does not work yet.
169 </div>
172 <div style="display:inline-block"> 170 <div style="display:inline-block">
173 <button style="font-size:20px" 171 <button style="font-size:20px"
174 ng-click="submitApprovals(filteredImagePairs)" 172 ng-click="submitApprovals(filteredImagePairs)"
175 ng-disabled="submitPending || (filteredImagePairs.length == 0) "> 173 ng-disabled="true || submitPending || (filteredImagePairs.leng th == 0)">
176 Update these {{filteredImagePairs.length}} expectations on the serve r 174 Update these {{filteredImagePairs.length}} expectations on the serve r
177 </button> 175 </button>
178 </div> 176 </div>
179 <div style="display:inline-block"> 177 <div style="display:inline-block">
180 <div style="font-size:20px" 178 <div style="font-size:20px"
181 ng-show="submitPending"> 179 ng-show="submitPending">
182 Submitting, please wait... 180 Submitting, please wait...
183 </div> 181 </div>
184 </div> 182 </div>
185 <div> 183 <div>
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 ng-click="toggleSomeImagePairs($index, imagePair[constants.KE Y__IMAGEPAIRS__ROWSPAN])"> 415 ng-click="toggleSomeImagePairs($index, imagePair[constants.KE Y__IMAGEPAIRS__ROWSPAN])">
418 </tr> 416 </tr>
419 </table> <!-- imagePairs --> 417 </table> <!-- imagePairs -->
420 </td></tr></table> <!-- table holding results header + imagePairs table --> 418 </td></tr></table> <!-- table holding results header + imagePairs table -->
421 419
422 </div><!-- main display area of selected tab --> 420 </div><!-- main display area of selected tab -->
423 </div><!-- everything: hide until readyToDisplay --> 421 </div><!-- everything: hide until readyToDisplay -->
424 422
425 </body> 423 </body>
426 </html> 424 </html>
OLDNEW
« no previous file with comments | « gm/rebaseline_server/static/live-loader.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698