gm/rebaseline_server/static/live-loader.js - Issue 467843002: rebaseline_server: only show Pending Approval tab if expectations vs actuals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/static/live-loader.js

Issue 467843002: rebaseline_server: only show Pending Approval tab if expectations vs actuals (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add link to raw JSON Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/static/live-loader.js

diff --git a/gm/rebaseline_server/static/live-loader.js b/gm/rebaseline_server/static/live-loader.js

index 16a19aab788a6fdcbdab39c1f51bc6950b30841e..3139d8799ba40a5e5de97a6953ebde4d817d7813 100644

--- a/gm/rebaseline_server/static/live-loader.js

+++ b/gm/rebaseline_server/static/live-loader.js

@@ -141,12 +141,12 @@ Loader.controller(

* Once the dictionary is loaded, unhide the page elements so they can

* render the data.

- var liveQueryUrl =

+ $scope.liveQueryUrl =

"/live-results/setADir=" + encodeURIComponent($scope.setADir) +

"&setASection=" + encodeURIComponent($scope.setASection) +

"&setBDir=" + encodeURIComponent($scope.setBDir) +

"&setBSection=" + encodeURIComponent($scope.setBSection);

- $http.get(liveQueryUrl).success(

+ $http.get($scope.liveQueryUrl).success(

function(data, status, header, config) {

var dataHeader = data[constants.KEY__ROOT__HEADER];

if (dataHeader[constants.KEY__HEADER__SCHEMA_VERSION] !=

« no previous file with comments | « gm/rebaseline_server/server.py ('k') | gm/rebaseline_server/static/live-view.html » ('j') | no next file with comments »