Issue 467843002: rebaseline_server: only show Pending Approval tab if expectations vs actuals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467843002: rebaseline_server: only show Pending Approval tab if expectations vs actuals (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years, 4 months ago

Reviewers:
rmistry

CC:
reviews_skia.org, stephana

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

rebaseline_server: only show Pending Approval tab if expectations vs actuals BUG=skia:1942 abandoning this CL, because I need to go in a different direction than patchset 2. committed patchsets 1 and 3 as: 1: https://codereview.chromium.org/465143004/ 3: https://codereview.chromium.org/475623002/

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -47 lines)			Patch
M	gm/rebaseline_server/server.py	View	1	7 chunks	+52 lines, -38 lines	0 comments	Download
M	gm/rebaseline_server/static/live-loader.js	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/rebaseline_server/static/live-view.html	View	1 2	2 chunks	+5 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

epoger

Ravi (and Stephan)- PTAL at patchset 3. Unlike the old GM mode, where people need ...

6 years, 4 months ago (2014-08-12 21:27:20 UTC) #1

epoger

6 years, 4 months ago (2014-08-12 23:03:30 UTC) #2

Actually, hold off on reviewing this.  I'm going to go back to the drawing board
on some of it.