Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 467303005: Remove implicit conversions from scoped_refptr to T* in ppapi/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/6d3ae97888924f8b6456c6f34c8da561da3797c6 Cr-Commit-Position: refs/heads/master@{#291806}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M ppapi/nacl_irt/manifest_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_io_resource.cc View 4 chunks +4 lines, -4 lines 2 comments Download
M ppapi/proxy/message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/platform_verification_private_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_resource_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_reply_thread_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/truetype_font_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/uma_private_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/video_decoder_resource.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M ppapi/shared_impl/tracked_callback.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
dcheng
6 years, 4 months ago (2014-08-25 19:52:17 UTC) #1
dmichael (off chromium)
https://codereview.chromium.org/467303005/diff/1/ppapi/proxy/file_io_resource.cc File ppapi/proxy/file_io_resource.cc (right): https://codereview.chromium.org/467303005/diff/1/ppapi/proxy/file_io_resource.cc#newcode52 ppapi/proxy/file_io_resource.cc:52: DCHECK(file_holder_.get()); I thought there was (or would be) a ...
6 years, 4 months ago (2014-08-25 19:55:12 UTC) #2
dcheng
https://codereview.chromium.org/467303005/diff/1/ppapi/proxy/file_io_resource.cc File ppapi/proxy/file_io_resource.cc (right): https://codereview.chromium.org/467303005/diff/1/ppapi/proxy/file_io_resource.cc#newcode52 ppapi/proxy/file_io_resource.cc:52: DCHECK(file_holder_.get()); On 2014/08/25 19:55:12, dmichael wrote: > I thought ...
6 years, 4 months ago (2014-08-25 19:56:39 UTC) #3
dmichael (off chromium)
On 2014/08/25 19:56:39, dcheng (OOO) wrote: > https://codereview.chromium.org/467303005/diff/1/ppapi/proxy/file_io_resource.cc > File ppapi/proxy/file_io_resource.cc (right): > > https://codereview.chromium.org/467303005/diff/1/ppapi/proxy/file_io_resource.cc#newcode52 ...
6 years, 4 months ago (2014-08-25 19:59:01 UTC) #4
dcheng
On 2014/08/25 at 19:59:01, dmichael wrote: > On 2014/08/25 19:56:39, dcheng (OOO) wrote: > > ...
6 years, 4 months ago (2014-08-25 20:01:20 UTC) #5
dmichael (off chromium)
On 2014/08/25 20:01:20, dcheng (OOO) wrote: > On 2014/08/25 at 19:59:01, dmichael wrote: > > ...
6 years, 4 months ago (2014-08-25 22:05:11 UTC) #6
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-25 22:22:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/467303005/1
6 years, 4 months ago (2014-08-25 22:24:12 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 23:18:21 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 00:06:31 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 00:06:32 UTC) #11
dcheng
Committed patchset #1 to pending queue manually as c05d50a (presubmit successful).
6 years, 4 months ago (2014-08-26 00:27:48 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d3ae97888924f8b6456c6f34c8da561da3797c6
Cr-Commit-Position: refs/heads/master@{#291806}

Powered by Google App Engine
This is Rietveld 408576698