Remove implicit conversions from scoped_refptr to T* in ppapi/

ppapi/proxy/file_io_resource.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/file_io_resource.h"
 
 #include "base/bind.h"
 #include "base/task_runner_util.h"
 #include "ipc/ipc_message.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 31 matching lines @@
 void DoClose(base::File auto_close_file) {
 }
 
 }  // namespace
 
 namespace ppapi {
 namespace proxy {
 
 FileIOResource::QueryOp::QueryOp(scoped_refptr<FileHolder> file_holder)
     : file_holder_(file_holder) {
-  DCHECK(file_holder_);
+  DCHECK(file_holder_.get());

[dmichael (off chromium), 2014/08/25 19:55:12]

I thought there was (or would be) a reasonable conversion to bool?

Best I can tell, this file doesn't need to be touched. If you can find a way to
make your tool detect the bool cases, you'll save a lot of churn in the code
base.

[dcheng, 2014/08/25 19:56:39]

Unfortunately, it's not possible to add a boolean conversion until the implicit
conversions to T* are removed--the conversion would be ambiguous.

 }
 
 FileIOResource::QueryOp::~QueryOp() {
 }
 
 int32_t FileIOResource::QueryOp::DoWork() {
   return file_holder_->file()->GetInfo(&file_info_) ? PP_OK : PP_ERROR_FAILED;
 }
 
 FileIOResource::ReadOp::ReadOp(scoped_refptr<FileHolder> file_holder,
                                int64_t offset,
                                int32_t bytes_to_read)
   : file_holder_(file_holder),
     offset_(offset),
     bytes_to_read_(bytes_to_read) {
-  DCHECK(file_holder_);
+  DCHECK(file_holder_.get());
 }
 
 FileIOResource::ReadOp::~ReadOp() {
 }
 
 int32_t FileIOResource::ReadOp::DoWork() {
   DCHECK(!buffer_.get());
   buffer_.reset(new char[bytes_to_read_]);
   return file_holder_->file()->Read(offset_, buffer_.get(), bytes_to_read_);
 }
@@ skipping 311 matching lines @@
   if (called_close_)
     return;
 
   called_close_ = true;
   if (check_quota_) {
     check_quota_ = false;
     file_system_resource_->AsPPB_FileSystem_API()->CloseQuotaFile(
         pp_resource());
   }
 
-  if (file_holder_)
+  if (file_holder_.get())
     file_holder_ = NULL;
 
   Post(BROWSER, PpapiHostMsg_FileIO_Close(
       FileGrowth(max_written_offset_, append_mode_write_amount_)));
 }
 
 int32_t FileIOResource::RequestOSFileHandle(
     PP_FileHandle* handle,
     scoped_refptr<TrackedCallback> callback) {
   int32_t rv = state_manager_.CheckOperationState(
@@ skipping 10 matching lines @@
   return PP_OK_COMPLETIONPENDING;
 }
 
 FileIOResource::FileHolder::FileHolder(PP_FileHandle file_handle)
     : file_(file_handle) {
 }
 
 // static
 bool FileIOResource::FileHolder::IsValid(
     const scoped_refptr<FileIOResource::FileHolder>& handle) {
-  return handle && handle->file_.IsValid();
+  return handle.get() && handle->file_.IsValid();
 }
 
 FileIOResource::FileHolder::~FileHolder() {
   if (file_.IsValid()) {
     base::TaskRunner* file_task_runner =
         PpapiGlobals::Get()->GetFileTaskRunner();
     file_task_runner->PostTask(FROM_HERE,
                                base::Bind(&DoClose, Passed(&file_)));
   }
 }
@@ skipping 267 matching lines @@
   *output_handle = IPC::PlatformFileForTransitToPlatformFile(transit_file);
 
   // End this operation now, so the user's callback can execute another FileIO
   // operation, assuming there are no other pending operations.
   state_manager_.SetOperationFinished();
   callback->Run(result);
 }
 
 }  // namespace proxy
 }  // namespace ppapi