Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 467243002: [gin] Allow interceptors to signal whether a they intercepted something (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
raymes, abarth-chromium
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[gin] Allow interceptors to signal whether a they intercepted something TEST=InterceptorTest.BypassInterceptor* R=abarth@chromium.org,raymes@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M gin/interceptor.h View 2 chunks +4 lines, -2 lines 0 comments Download
M gin/interceptor.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M gin/interceptor_unittest.cc View 3 chunks +29 lines, -8 lines 0 comments Download
M gin/object_template_builder.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-08-13 14:14:41 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-13 15:37:21 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 4 months ago (2014-08-13 15:59:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/467243002/1
6 years, 4 months ago (2014-08-13 16:00:29 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 17:13:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289325

Powered by Google App Engine
This is Rietveld 408576698