Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: gin/interceptor.h

Issue 467243002: [gin] Allow interceptors to signal whether a they intercepted something (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/interceptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/interceptor.h
diff --git a/gin/interceptor.h b/gin/interceptor.h
index 802929b83770bd316790f7d1c20f60b3f2380a7d..43cb3464fe97f5f3043b92adbb31540cd80fe461 100644
--- a/gin/interceptor.h
+++ b/gin/interceptor.h
@@ -25,7 +25,8 @@ class GIN_EXPORT NamedPropertyInterceptor {
virtual v8::Local<v8::Value> GetNamedProperty(v8::Isolate* isolate,
const std::string& property);
- virtual void SetNamedProperty(v8::Isolate* isolate,
+ // Return true if the set was interecepted.
+ virtual bool SetNamedProperty(v8::Isolate* isolate,
const std::string& property,
v8::Local<v8::Value> value);
virtual std::vector<std::string> EnumerateNamedProperties(
@@ -45,7 +46,8 @@ class GIN_EXPORT IndexedPropertyInterceptor {
virtual v8::Local<v8::Value> GetIndexedProperty(v8::Isolate* isolate,
uint32_t index);
- virtual void SetIndexedProperty(v8::Isolate* isolate,
+ // Return true if the set was interecepted.
+ virtual bool SetIndexedProperty(v8::Isolate* isolate,
uint32_t index,
v8::Local<v8::Value> value);
virtual std::vector<uint32_t> EnumerateIndexedProperties(
« no previous file with comments | « no previous file | gin/interceptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698