Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: gin/interceptor.cc

Issue 467243002: [gin] Allow interceptors to signal whether a they intercepted something (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/interceptor.h ('k') | gin/interceptor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/interceptor.cc
diff --git a/gin/interceptor.cc b/gin/interceptor.cc
index 7efc32ee68bf2c82d6e03b4ae1fb5f99aa2b3284..617fd08e26d6108239cf2852902a32cdb2bd4139 100644
--- a/gin/interceptor.cc
+++ b/gin/interceptor.cc
@@ -26,9 +26,11 @@ v8::Local<v8::Value> NamedPropertyInterceptor::GetNamedProperty(
return v8::Local<v8::Value>();
}
-void NamedPropertyInterceptor::SetNamedProperty(v8::Isolate* isolate,
+bool NamedPropertyInterceptor::SetNamedProperty(v8::Isolate* isolate,
const std::string& property,
- v8::Local<v8::Value> value) {}
+ v8::Local<v8::Value> value) {
+ return false;
+}
std::vector<std::string> NamedPropertyInterceptor::EnumerateNamedProperties(
v8::Isolate* isolate) {
@@ -51,10 +53,12 @@ v8::Local<v8::Value> IndexedPropertyInterceptor::GetIndexedProperty(
return v8::Local<v8::Value>();
}
-void IndexedPropertyInterceptor::SetIndexedProperty(
+bool IndexedPropertyInterceptor::SetIndexedProperty(
v8::Isolate* isolate,
uint32_t index,
- v8::Local<v8::Value> value) {}
+ v8::Local<v8::Value> value) {
+ return false;
+}
std::vector<uint32_t> IndexedPropertyInterceptor::EnumerateIndexedProperties(
v8::Isolate* isolate) {
« no previous file with comments | « gin/interceptor.h ('k') | gin/interceptor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698