Issue 467153002: Revert 289224 "Update ui::CompositorObserver instrumentation"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467153002: Revert 289224 "Update ui::CompositorObserver instrumentation" (Closed)

Created:
6 years, 4 months ago by Joao da Silva

Modified:
6 years, 4 months ago

Reviewers:
ccameron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 289224 "Update ui::CompositorObserver instrumentation" > Update ui::CompositorObserver instrumentation > > We'll want to make it the case that ui::CompositorObservers don't > outlive their ui::Compositors on all platforms. Update the instrumentation > and TODOs to reflect this, and move them to be behind DCHECK. > > BUG=403011 > > Review URL: https://codereview.chromium.org/467703003 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289229

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -9 lines)			Patch
M	trunk/src/ui/compositor/compositor.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	trunk/src/ui/compositor/compositor_observer.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/ui/compositor/compositor_observer.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Joao da Silva

6 years, 4 months ago (2014-08-13 09:34:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r289229 (tree was closed).