Update ui::CompositorObserver instrumentation

Update ui::CompositorObserver instrumentation

We'll want to make it the case that ui::CompositorObservers don't
outlive their ui::Compositors on all platforms. Update the instrumentation
and TODOs to reflect this, and move them to be behind DCHECK.

BUG=403011
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289224

[ccameron, 2014-08-12 20:10:08]

Update the TODOs, now that the issues on Mac are fixed.

[danakj, 2014-08-12 20:57:54]

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor.cc#...
ui/compositor/compositor.cc:282: CHECK(observer);
DCHECK?

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor_obs...
File ui/compositor/compositor_observer.cc (right):

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor_obs...
ui/compositor/compositor_observer.cc:20: #if defined(OS_MACOSX)
Did you wanna remove this?

[ccameron, 2014-08-12 21:04:24]

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor.cc#...
ui/compositor/compositor.cc:282: CHECK(observer);
On 2014/08/12 20:57:54, danakj wrote:
> DCHECK?

Done.

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor_obs...
File ui/compositor/compositor_observer.cc (right):

https://codereview.chromium.org/467703003/diff/1/ui/compositor/compositor_obs...
ui/compositor/compositor_observer.cc:20: #if defined(OS_MACOSX)
On 2014/08/12 20:57:54, danakj wrote:
> Did you wanna remove this?

Nah, I wanted to keep the DCHECK for Mac, and eventually delete the
defined(OS_MACOSX) -- there are a bazillion crashes if it's on for non-Mac ATM
(I filed a bug against that and assigned it to me).

[danakj, 2014-08-12 21:06:01]

LGTM

[ccameron, 2014-08-12 21:09:54]

Thanks!

[ccameron, 2014-08-12 21:09:57]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-08-12 21:14:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/467703003/20001

[commit-bot: I haz the power, 2014-08-13 02:05:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-13 09:07:29]

Change committed as 289224

[Joao da Silva, 2014-08-13 09:32:56]

Broke the build, going to revert this. See inline.

https://codereview.chromium.org/467703003/diff/20001/ui/compositor/compositor...
File ui/compositor/compositor_observer.cc (right):

https://codereview.chromium.org/467703003/diff/20001/ui/compositor/compositor...
ui/compositor/compositor_observer.cc:21: DCHECK_EQ(observing_count_, 0);
This is not defined if DCHECK_IS_ON is not defined

[Joao da Silva, 2014-08-13 09:33:05]

FYI:

http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/7811/s...