Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: trunk/src/ui/compositor/compositor.cc

Issue 467153002: Revert 289224 "Update ui::CompositorObserver instrumentation" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/ui/compositor/compositor_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/compositor/compositor.cc
===================================================================
--- trunk/src/ui/compositor/compositor.cc (revision 289228)
+++ trunk/src/ui/compositor/compositor.cc (working copy)
@@ -233,8 +233,10 @@
}
void Compositor::AddObserver(CompositorObserver* observer) {
-#if DCHECK_IS_ON
- DCHECK(observer);
+#if defined(OS_MACOSX)
+ // Debugging instrumentation for crbug.com/401630.
+ // TODO(ccameron): remove this.
+ CHECK(observer);
if (!observer_list_.HasObserver(observer))
observer->observing_count_ += 1;
#endif
@@ -243,7 +245,9 @@
}
void Compositor::RemoveObserver(CompositorObserver* observer) {
-#if DCHECK_IS_ON
+#if defined(OS_MACOSX)
+ // Debugging instrumentation for crbug.com/401630.
+ // TODO(ccameron): remove this.
if (observer_list_.HasObserver(observer))
observer->observing_count_ -= 1;
#endif
« no previous file with comments | « no previous file | trunk/src/ui/compositor/compositor_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698