Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 467133003: Remove webkitpy.thirdparty.mock, webkitpy.common.webkitunittest. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove webkitpy.thirdparty.mock, webkitpy.common.webkitunittest. More webkitpy cleanup. webkitunittest isn't needed once we required Python 2.7. mock.Mock() was really only being used in one file (and didn't need to be used there, either), and I'm not generally fan of the generic Mock approach it uses (preferring concrete mock objects or fakes). R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -382 lines) Patch
M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/Scripts/webkitpy/common/webkitunittest.py View 1 chunk +0 lines, -49 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 3 chunks +10 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/thirdparty/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
D Tools/Scripts/webkitpy/thirdparty/mock.py View 1 chunk +0 lines, -309 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/commandtest.py View 1 chunk +3 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-08-15 17:59:26 UTC) #1
Dirk Pranke
ping?
6 years, 4 months ago (2014-08-16 01:01:05 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-16 01:24:25 UTC) #3
Dirk Pranke
On 2014/08/16 01:24:25, abarth wrote: > lgtm thanks!
6 years, 4 months ago (2014-08-16 01:26:11 UTC) #4
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-08-16 01:26:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/467133003/1
6 years, 4 months ago (2014-08-16 01:26:44 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 03:05:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 180404

Powered by Google App Engine
This is Rietveld 408576698