Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

Issue 467133003: Remove webkitpy.thirdparty.mock, webkitpy.common.webkitunittest. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged 2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 """Unit tests for manager.py.""" 30 """Unit tests for manager.py."""
31 31
32 import sys 32 import sys
33 import time 33 import time
34 import unittest 34 import unittest
35 35
36 from webkitpy.common.host_mock import MockHost 36 from webkitpy.common.host_mock import MockHost
37 from webkitpy.layout_tests.controllers.manager import Manager 37 from webkitpy.layout_tests.controllers.manager import Manager
38 from webkitpy.layout_tests.models import test_expectations 38 from webkitpy.layout_tests.models import test_expectations
39 from webkitpy.layout_tests.models.test_run_results import TestRunResults 39 from webkitpy.layout_tests.models.test_run_results import TestRunResults
40 from webkitpy.thirdparty.mock import Mock
41 from webkitpy.tool.mocktool import MockOptions 40 from webkitpy.tool.mocktool import MockOptions
42 41
43 42
43 class FakePrinter(object):
44 def write_update(self, s):
45 pass
46
47
44 class ManagerTest(unittest.TestCase): 48 class ManagerTest(unittest.TestCase):
45 def test_needs_servers(self): 49 def test_needs_servers(self):
46 def get_manager(): 50 def get_manager():
47 port = Mock() # FIXME: Use a tighter mock. 51 host = MockHost()
48 port.TEST_PATH_SEPARATOR = '/' 52 port = host.port_factory.get('test-mac-leopard')
49 manager = Manager(port, options=MockOptions(http=True, max_locked_sh ards=1), printer=Mock()) 53 manager = Manager(port, options=MockOptions(http=True, max_locked_sh ards=1), printer=FakePrinter())
50 return manager 54 return manager
51 55
52 manager = get_manager() 56 manager = get_manager()
53 self.assertFalse(manager.needs_servers(['fast/html'])) 57 self.assertFalse(manager.needs_servers(['fast/html']))
54 58
55 manager = get_manager() 59 manager = get_manager()
56 self.assertTrue(manager.needs_servers(['http/tests/misc'])) 60 self.assertTrue(manager.needs_servers(['http/tests/misc']))
57 61
58 def test_servers_started(self): 62 def test_servers_started(self):
59 def get_manager(port): 63 def get_manager(port):
60 manager = Manager(port, options=MockOptions(http=True, max_locked_sh ards=1), printer=Mock()) 64 manager = Manager(port, options=MockOptions(http=True, max_locked_sh ards=1), printer=FakePrinter())
61 return manager 65 return manager
62 66
63 def start_http_server(additional_dirs, number_of_drivers): 67 def start_http_server(additional_dirs, number_of_drivers):
64 self.http_started = True 68 self.http_started = True
65 69
66 def start_websocket_server(): 70 def start_websocket_server():
67 self.websocket_started = True 71 self.websocket_started = True
68 72
69 def stop_http_server(): 73 def stop_http_server():
70 self.http_stopped = True 74 self.http_stopped = True
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 self.assertEqual(self.websocket_started, False) 106 self.assertEqual(self.websocket_started, False)
103 manager._stop_servers() 107 manager._stop_servers()
104 self.assertEqual(self.http_stopped, False) 108 self.assertEqual(self.http_stopped, False)
105 self.assertEqual(self.websocket_stopped, False) 109 self.assertEqual(self.websocket_stopped, False)
106 110
107 111
108 def test_look_for_new_crash_logs(self): 112 def test_look_for_new_crash_logs(self):
109 def get_manager(): 113 def get_manager():
110 host = MockHost() 114 host = MockHost()
111 port = host.port_factory.get('test-mac-leopard') 115 port = host.port_factory.get('test-mac-leopard')
112 manager = Manager(port, options=MockOptions(test_list=None, http=Tru e, max_locked_shards=1), printer=Mock()) 116 manager = Manager(port, options=MockOptions(test_list=None, http=Tru e, max_locked_shards=1), printer=FakePrinter())
113 return manager 117 return manager
114 host = MockHost() 118 host = MockHost()
115 port = host.port_factory.get('test-mac-leopard') 119 port = host.port_factory.get('test-mac-leopard')
116 tests = ['failures/expected/crash.html'] 120 tests = ['failures/expected/crash.html']
117 expectations = test_expectations.TestExpectations(port, tests) 121 expectations = test_expectations.TestExpectations(port, tests)
118 run_results = TestRunResults(expectations, len(tests)) 122 run_results = TestRunResults(expectations, len(tests))
119 manager = get_manager() 123 manager = get_manager()
120 manager._look_for_new_crash_logs(run_results, time.time()) 124 manager._look_for_new_crash_logs(run_results, time.time())
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/common/webkitunittest.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698