Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

Issue 467133003: Remove webkitpy.thirdparty.mock, webkitpy.common.webkitunittest. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py b/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
index 3e624dab89fcd7987cb210524c24143e4d8c7648..9c0ba86031e44fb555a388e63a20e2214f61820c 100644
--- a/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
@@ -37,16 +37,20 @@ from webkitpy.common.host_mock import MockHost
from webkitpy.layout_tests.controllers.manager import Manager
from webkitpy.layout_tests.models import test_expectations
from webkitpy.layout_tests.models.test_run_results import TestRunResults
-from webkitpy.thirdparty.mock import Mock
from webkitpy.tool.mocktool import MockOptions
+class FakePrinter(object):
+ def write_update(self, s):
+ pass
+
+
class ManagerTest(unittest.TestCase):
def test_needs_servers(self):
def get_manager():
- port = Mock() # FIXME: Use a tighter mock.
- port.TEST_PATH_SEPARATOR = '/'
- manager = Manager(port, options=MockOptions(http=True, max_locked_shards=1), printer=Mock())
+ host = MockHost()
+ port = host.port_factory.get('test-mac-leopard')
+ manager = Manager(port, options=MockOptions(http=True, max_locked_shards=1), printer=FakePrinter())
return manager
manager = get_manager()
@@ -57,7 +61,7 @@ class ManagerTest(unittest.TestCase):
def test_servers_started(self):
def get_manager(port):
- manager = Manager(port, options=MockOptions(http=True, max_locked_shards=1), printer=Mock())
+ manager = Manager(port, options=MockOptions(http=True, max_locked_shards=1), printer=FakePrinter())
return manager
def start_http_server(additional_dirs, number_of_drivers):
@@ -109,7 +113,7 @@ class ManagerTest(unittest.TestCase):
def get_manager():
host = MockHost()
port = host.port_factory.get('test-mac-leopard')
- manager = Manager(port, options=MockOptions(test_list=None, http=True, max_locked_shards=1), printer=Mock())
+ manager = Manager(port, options=MockOptions(test_list=None, http=True, max_locked_shards=1), printer=FakePrinter())
return manager
host = MockHost()
port = host.port_factory.get('test-mac-leopard')
« no previous file with comments | « Tools/Scripts/webkitpy/common/webkitunittest.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698