Move settings setup for PDF and cloud print into single location in PrintingContext

Move settings setup for PDF and cloud print into single location in PrintingContext.
Hard-code CloudPrint printable area until we start to receive this data from server.

BUG=305731
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232741

[Noam Samuel, 2013-10-31 17:46:18]

lgtm

[gene, 2013-10-31 18:29:41]

lgtm

[Lei Zhang, 2013-11-01 18:27:13]

lgtm

https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
File printing/print_settings_initializer_mac.cc (right):

https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
printing/print_settings_initializer_mac.cc:58:
DCHECK_EQ(print_settings->device_units_per_inch(), kPointsPerInch);
nit: reverse the two arguments. DCHECK_EQ(expected, actual) is preferred.

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
File printing/printing_context_mac.mm (right):

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
printing/printing_context_mac.mm:125: DCHECK(settings_.device_units_per_inch()
== kPointsPerInch);
nit: DCHECK_EQ

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
File printing/printing_context_win.cc (right):

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
printing/printing_context_win.cc:298: paper_size.SetSize(kLetterWidthInch,
kLetterHeightInch);
nit: can't you just do this in the SizeF ctor?

[Vitaly Buka (NO REVIEWS), 2013-11-01 19:35:09]

https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
File printing/print_settings_initializer_mac.cc (right):

https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
printing/print_settings_initializer_mac.cc:58:
DCHECK_EQ(print_settings->device_units_per_inch(), kPointsPerInch);
On 2013/11/01 18:27:13, Lei Zhang wrote:
> nit: reverse the two arguments. DCHECK_EQ(expected, actual) is preferred.

This looks like contradicts to example in logging.h
and inconsistent with comparison DCHECKs
usually if you need actual > expected
DCHECK_LE(actual, expected)

[Vitaly Buka (NO REVIEWS), 2013-11-01 19:39:31]

On 2013/11/01 19:35:09, Vitaly Buka wrote:
>
https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
> File printing/print_settings_initializer_mac.cc (right):
> 
>
https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
> printing/print_settings_initializer_mac.cc:58:
> DCHECK_EQ(print_settings->device_units_per_inch(), kPointsPerInch);
> On 2013/11/01 18:27:13, Lei Zhang wrote:
> > nit: reverse the two arguments. DCHECK_EQ(expected, actual) is preferred.
> 
> This looks like contradicts to example in logging.h
> and inconsistent with comparison DCHECKs
> usually if you need actual > expected
> DCHECK_LE(actual, expected)

My patch is inconsistent about this. I'd rather change all to DCHECK_EQ(actual,
expected)
but if you still prefer DCHECK_EQ(expected, actual), I'll do this way

[Vitaly Buka (NO REVIEWS), 2013-11-01 19:46:28]

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
File printing/printing_context_mac.mm (right):

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
printing/printing_context_mac.mm:125: DCHECK(settings_.device_units_per_inch()
== kPointsPerInch);
On 2013/11/01 18:27:13, Lei Zhang wrote:
> nit: DCHECK_EQ

Done.

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
File printing/printing_context_win.cc (right):

https://codereview.chromium.org/46623002/diff/280001/printing/printing_contex...
printing/printing_context_win.cc:298: paper_size.SetSize(kLetterWidthInch,
kLetterHeightInch);
On 2013/11/01 18:27:13, Lei Zhang wrote:
> nit: can't you just do this in the SizeF ctor?

Done.

[Lei Zhang, 2013-11-01 21:06:19]

On 2013/11/01 19:39:31, Vitaly Buka wrote:
> On 2013/11/01 19:35:09, Vitaly Buka wrote:
> >
>
https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
> > File printing/print_settings_initializer_mac.cc (right):
> > 
> >
>
https://codereview.chromium.org/46623002/diff/280001/printing/print_settings_...
> > printing/print_settings_initializer_mac.cc:58:
> > DCHECK_EQ(print_settings->device_units_per_inch(), kPointsPerInch);
> > On 2013/11/01 18:27:13, Lei Zhang wrote:
> > > nit: reverse the two arguments. DCHECK_EQ(expected, actual) is preferred.
> > 
> > This looks like contradicts to example in logging.h
> > and inconsistent with comparison DCHECKs
> > usually if you need actual > expected
> > DCHECK_LE(actual, expected)
> 
> My patch is inconsistent about this. I'd rather change all to
DCHECK_EQ(actual,
> expected)
> but if you still prefer DCHECK_EQ(expected, actual), I'll do this way

I've been told to do DCHECK_EQ(expected, actual) because that's the same order
as EXPECT_EQ(). I don't care strongly but at least be self consistent.

For the inequality checks, I don't think most people care about the order.

[commit-bot: I haz the power, 2013-11-01 22:33:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/600001

[commit-bot: I haz the power, 2013-11-01 23:09:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-01 23:23:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/600001

[commit-bot: I haz the power, 2013-11-01 23:48:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-02 05:49:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/600001

[commit-bot: I haz the power, 2013-11-02 06:10:24]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-03 02:04:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/600001

[commit-bot: I haz the power, 2013-11-03 02:25:41]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-03 02:32:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/1000001

[commit-bot: I haz the power, 2013-11-03 04:20:37]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-04 06:11:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/1000001

[commit-bot: I haz the power, 2013-11-04 08:42:38]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-04 18:28:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/46623002/1000001

[commit-bot: I haz the power, 2013-11-04 18:34:36]

Change committed as 232741