printing/print_dialog_gtk_interface.h - Issue 46623002: Move settings setup for PDF and cloud print into single location in PrintingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/print_dialog_gtk_interface.h

Issue 46623002: Move settings setup for PDF and cloud print into single location in PrintingContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/print_dialog_gtk_interface.h

diff --git a/printing/print_dialog_gtk_interface.h b/printing/print_dialog_gtk_interface.h

index 3b3fcddb9b6bb34b9b507689635bcb980e74f35d..e3506dd93590ea874bb5161bb421bc4d827093d1 100644

--- a/printing/print_dialog_gtk_interface.h

+++ b/printing/print_dialog_gtk_interface.h

@@ -24,11 +24,7 @@ class PrintDialogGtkInterface {

// Updates the dialog to use |settings|. Only used when printing without the

// system print dialog. E.g. for Print Preview. Returns false on error.

- // |target_is_pdf| is true if implementation needs to generate PDF without

- // actual printing. In this case implementation may avoid setup of native

- // print system. Ex. "save to pdf" or Cloud Print.

- virtual bool UpdateSettings(bool target_is_pdf,

- PrintSettings* settings) = 0;

+ virtual bool UpdateSettings(PrintSettings* settings) = 0;

// Shows the dialog and handles the response with |callback|. Only used when

// printing with the native print dialog.

« no previous file with comments | « chrome/browser/printing/print_dialog_gtk.cc ('k') | printing/print_settings.h » ('j') | no next file with comments »