Move settings setup for PDF and cloud print into single location in PrintingContext

printing/print_settings_initializer_mac.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/print_settings_initializer_mac.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "printing/print_settings.h"
+#include "printing/units.h"
 
 namespace printing {
 
 // static
 void PrintSettingsInitializerMac::InitPrintSettings(
     PMPrinter printer,
     PMPageFormat page_format,
     PrintSettings* print_settings) {
   print_settings->set_device_name(
       base::SysCFStringRefToUTF16(PMPrinterGetID(printer)));
@@ skipping 28 matching lines @@
   // Device units are in points. Units per inch is 72.
   gfx::Size physical_size_device_units(
       (paper_rect.right - paper_rect.left),
       (paper_rect.bottom - paper_rect.top));
   gfx::Rect printable_area_device_units(
       (page_rect.left - paper_rect.left),
       (page_rect.top - paper_rect.top),
       (page_rect.right - page_rect.left),
       (page_rect.bottom - page_rect.top));
 
+  DCHECK_EQ(print_settings->device_units_per_inch(), kPointsPerInch);

[Lei Zhang, 2013/11/01 18:27:13]

nit: reverse the two arguments. DCHECK_EQ(expected, actual) is preferred.

[Vitaly Buka (NO REVIEWS), 2013/11/01 19:35:09]

This looks like contradicts to example in logging.h
and inconsistent with comparison DCHECKs
usually if you need actual > expected
DCHECK_LE(actual, expected)

   print_settings->SetPrinterPrintableArea(physical_size_device_units,
                                           printable_area_device_units,
-                                          72, false);
+                                          false);
 }
 
 }  // namespace printing