Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 466193002: Disentangle blend mode from updateDescendantDependentFlags (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rosca, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Disentangle blend mode from updateDescendantDependentFlags Instead of driving the blend mode computation from updateDescendantDependentFlags, this CL drives the blend mode computation from CompositingInputsUpdater. Using this approach lets us remove a bunch of bookkeeping because CompositingInputsUpdater does all the bookkeeping for us. Because CompositingInputsUpdater happens during the compositing update, we need to add some code to the compositing update to run the CompositingInputsUpdater even when compositing isn't available (e.g., SVGImage and InspectorOverlay). R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -253 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 6 chunks +8 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 10 chunks +4 lines, -34 lines 0 comments Download
D Source/core/rendering/RenderLayerBlendInfo.h View 1 chunk +0 lines, -91 lines 0 comments Download
D Source/core/rendering/RenderLayerBlendInfo.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-13 00:23:47 UTC) #1
esprehn
lgtm, but it won't apply?
6 years, 4 months ago (2014-08-13 00:27:11 UTC) #2
abarth-chromium
On 2014/08/13 at 00:27:11, esprehn wrote: > lgtm, but it won't apply? It's based on ...
6 years, 4 months ago (2014-08-13 00:28:24 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-13 00:42:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/466193002/1
6 years, 4 months ago (2014-08-13 00:44:06 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 01:49:25 UTC) #6
Message was sent while issue was closed.
Change committed as 180133

Powered by Google App Engine
This is Rietveld 408576698