Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 468633002: hasSelfPaintingLayerDescendant should clean m_hasSelfPaintingLayerDescendantDirty (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, skobes, zoltan1
Project:
blink
Visibility:
Public.

Description

hasSelfPaintingLayerDescendant should clean m_hasSelfPaintingLayerDescendantDirty Previously, it was possible to read stale data from hasSelfPaintingLayerDescendant. After this CL, we clean out the dirty bit automatically when you read this state. In order to make this work, this CL separates hasSelfPaintingLayerDescendant from updateDescendantDependentFlags. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180124

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M Source/core/rendering/RenderLayer.h View 1 4 chunks +13 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 7 chunks +22 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-12 23:25:22 UTC) #1
esprehn
lgtm + nits https://codereview.chromium.org/468633002/diff/1/Source/core/rendering/RenderLayer.h File Source/core/rendering/RenderLayer.h (right): https://codereview.chromium.org/468633002/diff/1/Source/core/rendering/RenderLayer.h#newcode117 Source/core/rendering/RenderLayer.h:117: // FIXME: May people call this ...
6 years, 4 months ago (2014-08-12 23:27:53 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-12 23:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/468633002/20001
6 years, 4 months ago (2014-08-12 23:30:01 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 00:31:02 UTC) #5
Message was sent while issue was closed.
Change committed as 180124

Powered by Google App Engine
This is Rietveld 408576698