Chromium Code Reviews

Issue 465713002: Add linting for java libraries/apks to gn (Closed)

Created:
6 years, 4 months ago by cjhopman
Modified:
6 years, 4 months ago
Reviewers:
brettw, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lint-jar
Project:
chromium
Visibility:
Public.

Description

Add linting for java libraries/apks to gn BUG=359249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291240

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : Fix for multiple files with same basename #

Patch Set 6 : Fix bad symlinks #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Stats (+157 lines, -58 lines)
M build/android/gyp/lint.py View 4 chunks +93 lines, -53 lines 0 comments
M build/config/android/internal_rules.gni View 5 chunks +56 lines, -4 lines 0 comments
M build/config/android/rules.gni View 3 chunks +8 lines, -1 line 0 comments

Messages

Total messages: 10 (0 generated)
cjhopman
newt: *
6 years, 4 months ago (2014-08-18 01:27:23 UTC) #1
newt (away)
lgtm with a question https://codereview.chromium.org/465713002/diff/40001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/465713002/diff/40001/build/config/android/internal_rules.gni#newcode40 build/config/android/internal_rules.gni:40: "--config-path", rebase_path(suppressions_file, root_build_dir), Why is ...
6 years, 4 months ago (2014-08-18 16:12:16 UTC) #2
cjhopman
brettw for OWNERS
6 years, 4 months ago (2014-08-18 20:07:06 UTC) #3
cjhopman
ping https://codereview.chromium.org/465713002/diff/40001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/465713002/diff/40001/build/config/android/internal_rules.gni#newcode40 build/config/android/internal_rules.gni:40: "--config-path", rebase_path(suppressions_file, root_build_dir), On 2014/08/18 16:12:16, newt wrote: ...
6 years, 4 months ago (2014-08-20 21:44:59 UTC) #4
brettw
lgtm
6 years, 4 months ago (2014-08-20 22:24:38 UTC) #5
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 4 months ago (2014-08-21 17:26:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/465713002/100001
6 years, 4 months ago (2014-08-21 17:30:40 UTC) #7
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 4 months ago (2014-08-21 20:24:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/465713002/120001
6 years, 4 months ago (2014-08-21 20:28:44 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:27:27 UTC) #10
Message was sent while issue was closed. 
Committed patchset #7 (120001) as 291240

Powered by Google App Engine