Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: build/config/android/rules.gni

Issue 465713002: Add linting for java libraries/apks to gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lint-jar
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 211d01434d19f54362152442bd83c392867cb74c..d4c4ec759d9fc87c9c5df757197fe4ecac55c72e 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -405,7 +405,7 @@ template("java_strings_grd") {
# java_files: List of .java files included in this library.
# srcjar_deps: List of srcjar dependencies. The .java files in the srcjars
# will be added to java_files and be included in this library.
-#
+# chromium_code: If true, extra static analysis warning/errors will be enabled.
# jar_excluded_patterns: List of patterns of .class files to exclude from the
# final jar.
#
@@ -444,7 +444,13 @@ template("android_library") {
# base_path
}
+ _chromium_code = true
+ if (defined(invoker.chromium_code)) {
+ _chromium_code = invoker.chromium_code
+ }
+
android_java_library(target_name) {
+ chromium_code = _chromium_code
java_files = invoker.java_files
build_config = build_config
@@ -595,6 +601,7 @@ template("android_apk") {
final_deps += [":${target_name}__java"]
android_java_library("${target_name}__java") {
+ android_manifest = invoker.android_manifest
java_files = invoker.java_files
srcjar_deps = _srcjar_deps
dex_path = base_path + ".dex.jar"
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698