Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 465143003: Assert if we try to access another AX attribute while a layout is pending. (Closed)

Created:
6 years, 4 months ago by dmazzoni
Modified:
6 years, 4 months ago
Reviewers:
dglazkov
CC:
aboxhall, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Assert if we try to access another AX attribute while a layout is pending. Actual fix for crash is in https://codereview.chromium.org/469803003 BUG=393829 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180739

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
A LayoutTests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dmazzoni
6 years, 4 months ago (2014-08-13 19:24:49 UTC) #1
dglazkov
lgtm
6 years, 4 months ago (2014-08-13 22:37:25 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-13 22:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/465143003/1
6 years, 4 months ago (2014-08-13 23:00:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-14 03:36:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 04:16:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22689)
6 years, 4 months ago (2014-08-14 04:16:14 UTC) #7
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-20 23:41:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/465143003/1
6 years, 4 months ago (2014-08-20 23:41:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-20 23:47:50 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 23:49:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20631)
6 years, 4 months ago (2014-08-20 23:49:48 UTC) #12
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-21 16:21:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/465143003/20001
6 years, 4 months ago (2014-08-21 16:23:36 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-21 21:04:14 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:43:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180739

Powered by Google App Engine
This is Rietveld 408576698