Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 469803003: Ensure there's no layout pending before accessing WebAXObject from TestRunner. (Closed)

Created:
6 years, 4 months ago by dmazzoni
Modified:
6 years, 4 months ago
Reviewers:
dglazkov
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Ensure there's no layout pending before accessing WebAXObject from TestRunner. It's not safe to call WebAXObject functions when there's a layout pending. Chrome never does this, it only calls WebAXObject from renderer_accessibility_complete, and it makes sure to update layout before accessing the accessibility tree. TestRunner didn't have the same protections, so this just explicitly updates the layout before any accessibility call. BUG=393829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -83 lines) Patch
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 10 chunks +143 lines, -83 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
The test is in https://codereview.chromium.org/465143003
6 years, 4 months ago (2014-08-13 19:24:41 UTC) #1
dglazkov
lgtm
6 years, 4 months ago (2014-08-13 22:39:02 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-13 22:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/469803003/1
6 years, 4 months ago (2014-08-13 23:00:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 289489
6 years, 4 months ago (2014-08-14 08:11:24 UTC) #5
dmazzoni
Re-landing after fixing flaky layout test that failed after the first time I tried to ...
6 years, 4 months ago (2014-08-20 17:27:20 UTC) #6
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 4 months ago (2014-08-20 17:27:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/469803003/1
6 years, 4 months ago (2014-08-20 17:28:20 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 18:59:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 290880

Powered by Google App Engine
This is Rietveld 408576698