Assert if we try to access another AX attribute while a layout is pending.

Source/web/WebAXObject.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 #include "core/rendering/style/RenderStyle.h"
 #include "platform/PlatformKeyboardEvent.h"
 #include "public/platform/WebPoint.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
 #include "public/web/WebDocument.h"
 #include "public/web/WebNode.h"
 #include "wtf/text/StringBuilder.h"
 
+using namespace blink;
+
 namespace blink {
 
+#if ENABLE(ASSERT)
+// It's not safe to call some WebAXObject APIs if a layout is pending.
+// Clients should call updateLayoutAndCheckValidity first.
+static bool isLayoutClean(Document* document)
+{
+    if (!document || !document->view())
+        return false;
+    return document->lifecycle().state() >= DocumentLifecycle::LayoutClean
+        || (document->lifecycle().state() == DocumentLifecycle::StyleClean && !document->view()->needsLayout());
+}
+#endif
+
 void WebAXObject::reset()
 {
     m_private.reset();
 }
 
 void WebAXObject::assign(const WebAXObject& other)
 {
     m_private = other.m_private;
 }
 
@@ skipping 52 matching lines @@
 bool WebAXObject::updateBackingStoreAndCheckValidity()
 {
     return updateLayoutAndCheckValidity();
 }
 
 WebString WebAXObject::accessibilityDescription() const
 {
     if (isDetached())
         return WebString();
 
+    ASSERT(isLayoutClean(m_private->document()));
+
     return m_private->accessibilityDescription();
 }
 
 WebString WebAXObject::actionVerb() const
 {
     if (isDetached())
         return WebString();
 
     return m_private->actionVerb();
 }
@@ skipping 394 matching lines @@
     m_private->ariaOwnsElements(owns);
 
     WebVector<WebAXObject> result(owns.size());
     for (size_t i = 0; i < owns.size(); i++)
         result[i] = WebAXObject(owns[i]);
     ownsElements.swap(result);
 
     return true;
 }
 
-#if ENABLE(ASSERT)
-static bool isLayoutClean(Document* document)
-{
-    if (!document || !document->view())
-        return false;
-    return document->lifecycle().state() >= DocumentLifecycle::LayoutClean
-        || (document->lifecycle().state() == DocumentLifecycle::StyleClean && !document->view()->needsLayout());
-}
-#endif
-
 WebRect WebAXObject::boundingBoxRect() const
 {
     if (isDetached())
         return WebRect();
 
-    // It's not safe to call boundingBoxRect if a layout is pending.
-    // Clients should call updateLayoutAndCheckValidity first.
     ASSERT(isLayoutClean(m_private->document()));
 
     return pixelSnappedIntRect(m_private->elementRect());
 }
 
 bool WebAXObject::canvasHasFallbackContent() const
 {
     if (isDetached())
         return false;
 
@@ skipping 203 matching lines @@
         return WebString();
 
     return m_private->stringValue();
 }
 
 WebString WebAXObject::title() const
 {
     if (isDetached())
         return WebString();
 
+    ASSERT(isLayoutClean(m_private->document()));
+
     return m_private->title();
 }
 
 WebAXObject WebAXObject::titleUIElement() const
 {
     if (isDetached())
         return WebAXObject();
 
     if (!m_private->exposesTitleUIElement())
         return WebAXObject();
@@ skipping 374 matching lines @@
     m_private = object;
     return *this;
 }
 
 WebAXObject::operator WTF::PassRefPtr<AXObject>() const
 {
     return m_private.get();
 }
 
 } // namespace blink