[Telemetry] Move failure reasoning into summary.py.

[Telemetry] Move failure reasoning into summary.py.

Previously, we were having Summary take a boolean had_failures. Now that
failures are part of Telemetry's value system, it is easy to have Summary
reason about how to summarize values when failures and/or skips are present.
This CL is the first step: it eliminates had_failures from being passed around
and instead computes it directly based on the presence of failures in the
passed list of page-specific values.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289556

[eakuefner, 2014-08-12 21:53:41]

I want to use this CL to facilitate a discussion on how or if we ought to modify
summarization behavior based on the new way we are handling failures and skips.

It seems like Buildbot may expect the way that summarization occurs when
failures/skips are present to behave a certain specific way though I'm not sure
if this is correct.

In any case, this CL does make a logical first step of making summary.Summary
reason about failures itself, rather than simply deciding what to do based on a
passed boolean.

[nduca, 2014-08-13 00:57:30]

lgtm

[eakuefner, 2014-08-13 00:57:42]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2014-08-13 01:08:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eakuefner@chromium.org/465063002/1

[chrishenry - DO NOT USE, 2014-08-13 04:15:33]

lgtm

https://codereview.chromium.org/465063002/diff/1/tools/telemetry/telemetry/va...
File tools/telemetry/telemetry/value/summary.py (right):

https://codereview.chromium.org/465063002/diff/1/tools/telemetry/telemetry/va...
tools/telemetry/telemetry/value/summary.py:40: failure.FailureValue)]) > 0)
Please use:
any(isinstance(v, failure.FailureValue) for v in all_page_specific_values)

[eakuefner, 2014-08-13 04:28:06]

The CQ bit was unchecked by eakuefner@chromium.org

[eakuefner, 2014-08-14 00:33:26]

https://codereview.chromium.org/465063002/diff/1/tools/telemetry/telemetry/va...
File tools/telemetry/telemetry/value/summary.py (right):

https://codereview.chromium.org/465063002/diff/1/tools/telemetry/telemetry/va...
tools/telemetry/telemetry/value/summary.py:40: failure.FailureValue)]) > 0)
On 2014/08/13 04:15:33, chrishenry - DO NOT USE wrote:
> Please use:
> any(isinstance(v, failure.FailureValue) for v in all_page_specific_values)

Done, thanks for pointing this out, it's quite elegant.

[eakuefner, 2014-08-14 00:33:30]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2014-08-14 00:37:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eakuefner@chromium.org/465063002/20001

[commit-bot: I haz the power, 2014-08-14 12:44:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 14:19:25]

Committed patchset #2 (20001) as 289556