tools/telemetry/telemetry/value/summary.py - Issue 465063002: [Telemetry] Move failure reasoning into summary.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/summary.py

Issue 465063002: [Telemetry] Move failure reasoning into summary.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Chris's comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/summary.py

diff --git a/tools/telemetry/telemetry/value/summary.py b/tools/telemetry/telemetry/value/summary.py

index f9d372d443712a1b1c6b47abc9011bb4114d35eb..13e8ac20dfc52ba5b387fa9940d4d82099cbc6f5 100644

--- a/tools/telemetry/telemetry/value/summary.py

+++ b/tools/telemetry/telemetry/value/summary.py

@@ -35,7 +35,9 @@ class Summary(object):

]

"""

- def __init__(self, all_page_specific_values, had_failures):

+ def __init__(self, all_page_specific_values):

+ had_failures = any(isinstance(v, failure.FailureValue) for v in

+ all_page_specific_values)

self.had_failures = had_failures

self._computed_per_page_values = []

self._computed_summary_values = []

« no previous file with comments | « tools/telemetry/telemetry/results/buildbot_output_formatter.py ('k') | no next file » | no next file with comments »