tools/telemetry/telemetry/results/buildbot_output_formatter.py - Issue 465063002: [Telemetry] Move failure reasoning into summary.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/buildbot_output_formatter.py

Issue 465063002: [Telemetry] Move failure reasoning into summary.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Chris's comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/results/buildbot_output_formatter.py

diff --git a/tools/telemetry/telemetry/results/buildbot_output_formatter.py b/tools/telemetry/telemetry/results/buildbot_output_formatter.py

index cdb33fc2649711adeb9789740ff6cc5a7b3670ab..cbe15b0e8afd0dbc86f85949d1d0c603bd9076e6 100644

--- a/tools/telemetry/telemetry/results/buildbot_output_formatter.py

+++ b/tools/telemetry/telemetry/results/buildbot_output_formatter.py

@@ -31,8 +31,7 @@ class BuildbotOutputFormatter(output_formatter.OutputFormatter):

# Print out the list of unique pages.

perf_tests_helper.PrintPages(

[page.display_name for page in page_test_results.pages_that_succeeded])

- summary = summary_module.Summary(page_test_results.all_page_specific_values,

- had_failures)

+ summary = summary_module.Summary(page_test_results.all_page_specific_values)

for value in summary.interleaved_computed_per_page_values_and_summaries:

if value.page:

self._PrintComputedPerPageValue(value)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/summary.py » ('j') | no next file with comments »