Add layer counting to SkPictureRecord

Add layer counting to SkPictureRecord

This will be used for a SkPicture::suitableForOptimization entry point.

Committed: https://skia.googlesource.com/skia/+/4a2b2e8ed2e35171bf98bad68a69daaced11ec7c

Committed: https://skia.googlesource.com/skia/+/c019ec412ba2704bc6e2cdfd321ea06787ba415d

[bsalomon, 2014-08-11 20:07:38]

lgtm 

I'd maybe call it interior rather than nesting layer just b/c that's the usual
lingo I hear wrt to trees (interior vs leaf nodes).

https://codereview.chromium.org/464433002/diff/60001/src/core/SkPictureConten...
File src/core/SkPictureContentInfo.h (right):

https://codereview.chromium.org/464433002/diff/60001/src/core/SkPictureConten...
src/core/SkPictureContentInfo.h:76: SkTDArray<int> fSaveStack;
I think we usually use uint32_t for bitfields.

[robertphillips, 2014-08-11 20:53:27]

Please take another look. I've add the usage in the experimental optimize
method.

Note that the current counting is overkill for the current use but I would like
to try using the interior/leaf counts in the suitableForGpuRasterization method.

https://codereview.chromium.org/464433002/diff/60001/src/core/SkPictureConten...
File src/core/SkPictureContentInfo.h (right):

https://codereview.chromium.org/464433002/diff/60001/src/core/SkPictureConten...
src/core/SkPictureContentInfo.h:76: SkTDArray<int> fSaveStack;
On 2014/08/11 20:07:38, bsalomon wrote:
> I think we usually use uint32_t for bitfields.

Done.

[bsalomon, 2014-08-11 20:58:21]

https://codereview.chromium.org/464433002/diff/100001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/464433002/diff/100001/include/core/SkPicture....
include/core/SkPicture.h:191: bool suitableForOptimization() const;
This seems really general. It's really about suitability for a particular type
of optimization. Is the concern about publicly exposing low level detail about
the layer count?

[robertphillips, 2014-08-11 21:17:49]

Here is a slightly lower level implementation of the layer hoisting optimization
short circuit.

https://codereview.chromium.org/464433002/diff/100001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/464433002/diff/100001/include/core/SkPicture....
include/core/SkPicture.h:191: bool suitableForOptimization() const;
Right - we don't want the picture stats to be API-level visible.

[bsalomon, 2014-08-11 21:30:08]

lgtm

[robertphillips, 2014-08-11 21:36:59]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-08-11 21:37:37]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/464433002/1...

[commit-bot: I haz the power, 2014-08-11 21:45:43]

Change committed as 4a2b2e8ed2e35171bf98bad68a69daaced11ec7c

[mtklein, 2014-08-11 22:18:54]

A revert of this CL has been created in
https://codereview.chromium.org/452673003/ by mtklein@google.com.

The reason for reverting is: DM's all segfaulty

http://108.170.220.120:10117/builders/Test-Mac10.7-MacMini4.1-GeForce320M-x86....

[robertphillips, 2014-08-12 12:27:47]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-08-12 12:29:05]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/464433002/1...

[commit-bot: I haz the power, 2014-08-12 12:36:04]

Change committed as c019ec412ba2704bc6e2cdfd321ea06787ba415d