athena: Fix switching to a window of a different size.

athena: Fix switching to a window of a different size.

When title-dragging to switch to a window that is of a different size (e.g.
because it the new window was split), then make sure the window is positioned
correclty during the title-drag gesture, and sized correctly at the end of
the gesture. Also make sure that the window that the user switched away from
is hidden after the gesture.

BUG=none
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290950

[oshima, 2014-08-20 13:41:59]

lgtm with nits and q

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:280: dx += (window->bounds().width() -
next_window->bounds().width()) / 2;
could be just me and you may ignore but

dy -= (next - window) / 2;

maybe slightly easier to read.

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:306: gfx::Transform())));
I'd be nice to have a utility observer to set the final bounds after animation.

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:316: window->Hide();
Is this important now? looks like we show all windows in overview mode but never
hide windows behind active window(s), so a window behind it.

I agree that we need to implement this state (sorry it was on my plate)

[sadrul, 2014-08-20 22:34:25]

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:280: dx += (window->bounds().width() -
next_window->bounds().width()) / 2;
On 2014/08/20 13:41:59, oshima wrote:
> could be just me and you may ignore but
> 
> dy -= (next - window) / 2;
> 
> maybe slightly easier to read.

Done.

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:306: gfx::Transform())));
On 2014/08/20 13:41:59, oshima wrote:
> I'd be nice to have a utility observer to set the final bounds after
animation.

Done.

https://codereview.chromium.org/464163005/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:316: window->Hide();
On 2014/08/20 13:41:59, oshima wrote:
> Is this important now? looks like we show all windows in overview mode but
never
> hide windows behind active window(s), so a window behind it.
> 
> I agree that we need to implement this state (sorry it was on my plate)
> 

It's not important in the sense that not doing a Hide() here doesn't break
anything visually. But I am adding it explicitly here since we explicitly do a
Show() in OnTitleDragStarted().

I plan on having the overview controller also hide the windows when we get out
of the overview mode (since it explicitly makes them all visible when going into
overview mode too). It's a little trickier though, since it needs to know about
split-view mode and left/right windows. I have a plan for fixing that though,
and will address it in a follow-up CL.

[sadrul, 2014-08-20 23:44:45]

Committed patchset #2 manually as 290950 (presubmit successful).