pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart - Issue 462403005: Move Location factories and RefactoringProblemSeverity.max into the generated classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

Issue 462403005: Move Location factories and RefactoringProblemSeverity.max into the generated classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rename to 'fromX'. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/extract_local.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

index 6e8c6425331fbe564598b8dc0350e2dfe8be6a60..0f5f42bf1f1416b0889f1cb79c6a8ad9d94257b4 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

@@ -6,7 +6,7 @@ library services.src.refactoring.rename_class_member;

import 'dart:async';

-import 'package:analysis_server/src/protocol2.dart' show SourceEdit;

+import 'package:analysis_server/src/protocol2.dart' show Location, SourceEdit;

import 'package:analysis_server/src/services/correction/change.dart';

import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

@@ -149,7 +149,7 @@ class _RenameClassMemberValidator {

elementClass.displayName,

getElementKindName(newNameMember),

newName),

- createLocation_forElement(newNameMember));

+ new Location.fromElement(newNameMember));

}

// do chained computations

Set<ClassElement> superClasses = getSuperClasses(elementClass);

@@ -172,7 +172,7 @@ class _RenameClassMemberValidator {

getElementKindName(element),

getElementKindName(nameElement),

getElementQualifiedName(nameElement)),

- createLocation_forElement(nameElement));

+ new Location.fromElement(nameElement));

}

// renamed Element is shadowed by member of subclass

if (subClasses.contains(nameClass)) {

@@ -182,7 +182,7 @@ class _RenameClassMemberValidator {

getElementKindName(element),

getElementKindName(nameElement),

getElementQualifiedName(nameElement)),

- createLocation_forElement(nameElement));

+ new Location.fromElement(nameElement));

}

// renamed Element is shadowed by local

if (nameElement is LocalElement) {

@@ -199,7 +199,7 @@ class _RenameClassMemberValidator {

getElementKindName(element),

getElementKindName(localElement),

localElement.displayName),

- createLocation_forMatch(reference));

+ new Location.fromMatch(reference));

}