Move Location factories and RefactoringProblemSeverity.max into the generated classes.

pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.refactoring.rename_class_member;
 
 import 'dart:async';
 
-import 'package:analysis_server/src/protocol2.dart' show SourceEdit;
+import 'package:analysis_server/src/protocol2.dart' show Location, SourceEdit;
 import 'package:analysis_server/src/services/correction/change.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/search/hierarchy.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
 import 'package:analysis_server/src/services/refactoring/rename.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/java_core.dart';
@@ skipping 122 matching lines @@
     RefactoringStatus result = new RefactoringStatus();
     ClassElement elementClass = element.enclosingElement;
     // check if there is a member with "newName" in the same ClassElement
     for (Element newNameMember in getChildren(elementClass, newName)) {
       result.addError(
           format(
               "Class '{0}' already declares {1} with name '{2}'.",
               elementClass.displayName,
               getElementKindName(newNameMember),
               newName),
-          createLocation_forElement(newNameMember));
+          new Location.fromElement(newNameMember));
     }
     // do chained computations
     Set<ClassElement> superClasses = getSuperClasses(elementClass);
     Set<ClassElement> subClasses;
     return _prepareReferences().then((_) {
       return getSubClasses(searchEngine, elementClass).then((_subs) {
         subClasses = _subs;
       });
     }).then((_) {
       // check shadowing in hierarchy
       return searchEngine.searchElementDeclarations(newName).then((decls) {
         for (SearchMatch decl in decls) {
           Element nameElement = getSyntheticAccessorVariable(decl.element);
           Element nameClass = nameElement.enclosingElement;
           // renamed Element shadows member of superclass
           if (superClasses.contains(nameClass)) {
             result.addError(
                 format(
                     "Renamed {0} will shadow {1} '{2}'.",
                     getElementKindName(element),
                     getElementKindName(nameElement),
                     getElementQualifiedName(nameElement)),
-                createLocation_forElement(nameElement));
+                new Location.fromElement(nameElement));
           }
           // renamed Element is shadowed by member of subclass
           if (subClasses.contains(nameClass)) {
             result.addError(
                 format(
                     "Renamed {0} will be shadowed by {1} '{2}'.",
                     getElementKindName(element),
                     getElementKindName(nameElement),
                     getElementQualifiedName(nameElement)),
-                createLocation_forElement(nameElement));
+                new Location.fromElement(nameElement));
           }
           // renamed Element is shadowed by local
           if (nameElement is LocalElement) {
             LocalElement localElement = nameElement;
             ClassElement enclosingClass =
                 nameElement.getAncestor((element) => element is ClassElement);
             if (enclosingClass == elementClass ||
                 subClasses.contains(enclosingClass)) {
               for (SearchMatch reference in references) {
                 if (isReferenceInLocalRange(localElement, reference)) {
                   result.addError(
                       format(
                           "Usage of renamed {0} will be shadowed by {1} '{2}'.",
                           getElementKindName(element),
                           getElementKindName(localElement),
                           localElement.displayName),
-                      createLocation_forMatch(reference));
+                      new Location.fromMatch(reference));
                 }
               }
             }
           }
         }
       });
     }).then((_) => result);
   }
 
   /**
@@ skipping 18 matching lines @@
   Future _prepareReferences() {
     return _prepareElements().then((_) {
       return Future.forEach(elements, (Element element) {
         return searchEngine.searchReferences(element).then((references) {
           this.references.addAll(references);
         });
       });
     });
   }
 }