pkg/analysis_server/lib/src/services/refactoring/extract_local.dart - Issue 462403005: Move Location factories and RefactoringProblemSeverity.max into the generated classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

Issue 462403005: Move Location factories and RefactoringProblemSeverity.max into the generated classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rename to 'fromX'. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/status.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

index 37a8791e708be91af278703cf4e630f4af4f2d6f..0f43805ac4a631e6a28b2bcb94eb0d74cd5c045e 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

@@ -383,7 +383,7 @@ class _ExtractExpressionAnalyzer extends SelectionAnalyzer {

if (_isFirstSelectedNode(lhs)) {

_invalidSelection(

'Cannot extract the left-hand side of an assignment.',

- createLocation_forNode(lhs));

+ new Location.fromNode(lhs));

}

return null;

}