Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 462203002: Add override to force bitmap rendering (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverse logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
krajcevski
6 years, 4 months ago (2014-08-12 20:20:03 UTC) #1
robertphillips
https://codereview.chromium.org/462203002/diff/1/src/gpu/GrSWMaskHelper.h File src/gpu/GrSWMaskHelper.h (right): https://codereview.chromium.org/462203002/diff/1/src/gpu/GrSWMaskHelper.h#newcode51 src/gpu/GrSWMaskHelper.h:51: // allows the caller to specify the region of ...
6 years, 4 months ago (2014-08-13 14:03:17 UTC) #2
krajcevski
https://codereview.chromium.org/462203002/diff/1/src/gpu/GrSWMaskHelper.h File src/gpu/GrSWMaskHelper.h (right): https://codereview.chromium.org/462203002/diff/1/src/gpu/GrSWMaskHelper.h#newcode51 src/gpu/GrSWMaskHelper.h:51: // allows the caller to specify the region of ...
6 years, 4 months ago (2014-08-13 15:16:35 UTC) #3
robertphillips
lgtm
6 years, 4 months ago (2014-08-13 16:09:42 UTC) #4
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-13 16:19:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/462203002/20001
6 years, 4 months ago (2014-08-13 16:21:06 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 17:36:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 71614ac7c63fe60dfe971f861e2b2d6325dd0039

Powered by Google App Engine
This is Rietveld 408576698