Remove custom style building functions for 'clip'.

Remove custom style building functions for 'clip'.

The property 'clip' is (with some modifications) compatible with the
apply_auto-properties.

Changes in this commit:

 * Use apply_auto + converter instead of custom building functions.
 * StyleVisualData::hasClip -> hasAutoClip (meaning reversed).
 * Remove unnecessary RenderStyle::setClip*-functions.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180465

[rune, 2014-08-13 08:50:16]

lgtm

[andersr, 2014-08-13 09:30:08]

This depends (slightly) on timloh's CSSProperties.in-patches, which recently got
reverted. I think they're back now (or on their way), but let's wait a few days
before landing, to make sure they stick this time.

Also, forgot to mention that this depends on
https://codereview.chromium.org/454133004/ .

[Timothy Loh, 2014-08-13 09:57:27]

On 2014/08/13 09:30:08, andersr wrote:
> This depends (slightly) on timloh's CSSProperties.in-patches, which recently
got
> reverted. I think they're back now (or on their way), but let's wait a few
days
> before landing, to make sure they stick this time.
> 
> Also, forgot to mention that this depends on
> https://codereview.chromium.org/454133004/ .

Yep, you might want to wait for https://codereview.chromium.org/454423003/ and
https://codereview.chromium.org/450103005/ to re-land first to save both of us
some rebase hassle. I'm waiting for the next roll to make sure
https://codereview.chromium.org/415613002/ sticks before landing these.

[Timothy Loh, 2014-08-13 10:06:18]

lgtm

https://codereview.chromium.org/462133002/diff/1/Source/core/rendering/style/...
File Source/core/rendering/style/RenderStyle.h (right):

https://codereview.chromium.org/462133002/diff/1/Source/core/rendering/style/...
Source/core/rendering/style/RenderStyle.h:545: bool hasClip() const { return
!visual->hasAutoClip; }
I would've just removed this instead of having two functions for the same thing.
Looks like it makes the animations and computed style code paths slightly
clearer too if you use hasAutoClip.

[andersr, 2014-08-18 09:41:31]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-08-18 09:41:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/462133002/20001

[commit-bot: I haz the power, 2014-08-18 09:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 09:42:09]

Failed to apply patch for
Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
  Hunk #1 succeeded at 40 with fuzz 1 (offset 7 lines).
  Hunk #2 FAILED at 74.
  Hunk #3 FAILED at 123.
  Hunk #4 FAILED at 149.
  3 out of 4 hunks FAILED -- saving rejects to file
Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl.rej

Patch:       Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
index
789dccccc5a63c15ad64e4c49fd5fefc1e150662..7568d7ec24d08fc99f57b052fe366560132109fb
100644
--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
@@ -33,6 +33,13 @@ state.fontBuilder().{{property.setter}}
 state.style()->{{property.setter}}
 {%- endif %}
 {% endmacro %}
+{% macro convert_and_set_value(property) %}
+{% if property.converter %}
+{{set_value(property)}}(StyleBuilderConverter::{{property.converter}}(state,
value));
+{%- else %}
+{{set_value(property)}}(static_cast<{{property.type_name}}>(*toCSSPrimitiveValue(value)));
+{%- endif %}
+{% endmacro %}
 
 namespace blink {
 
@@ -67,11 +74,7 @@ namespace blink {
 {% if not property.custom_value %}
 {{declare_value_function(property_id)}}
 {
-    {% if property.converter %}
-   
{{set_value(property)}}(StyleBuilderConverter::{{property.converter}}(state,
value));
-    {% else %}
-   
{{set_value(property)}}(static_cast<{{property.type_name}}>(*toCSSPrimitiveValue(value)));
-    {% endif %}
+    {{convert_and_set_value(property)}}
 }
 
 {% endif %}
@@ -116,7 +119,7 @@ namespace blink {
 {{apply_animation('CSSPropertyWebkitTransitionProperty', 'Property',
'Transition')}}
 {{apply_animation('CSSPropertyWebkitTransitionTimingFunction',
'TimingFunction', 'Transition')}}
 
-{% macro apply_auto(property_id, auto_getter=none, auto_setter=none,
auto_identity='CSSValueAuto', compute_length=false) %}
+{% macro apply_auto(property_id, auto_getter=none, auto_setter=none,
auto_identity='CSSValueAuto') %}
 {% set property = properties[property_id] %}
 {% set auto_getter = auto_getter or 'hasAuto' + property.name_for_methods %}
 {% set auto_setter = auto_setter or 'setHasAuto' + property.name_for_methods %}
@@ -142,17 +145,14 @@ namespace blink {
     if (primitiveValue->getValueID() == {{auto_identity}})
         state.style()->{{auto_setter}}();
     else
-        {% if compute_length %}
-       
{{set_value(property)}}(primitiveValue->computeLength<{{property.type_name}}>(state.cssToLengthConversionData()));
-        {% else %}
-        {{set_value(property)}}(*primitiveValue);
-        {% endif %}
+        {{convert_and_set_value(property)}}
 }
 {% endmacro %}
+{{apply_auto('CSSPropertyClip')}}
 {{apply_auto('CSSPropertyOrphans')}}
 {{apply_auto('CSSPropertyWebkitColumnCount')}}
-{{apply_auto('CSSPropertyWebkitColumnGap', auto_getter='hasNormalColumnGap',
auto_setter='setHasNormalColumnGap', auto_identity='CSSValueNormal',
compute_length=true)}}
-{{apply_auto('CSSPropertyWebkitColumnWidth', compute_length=true)}}
+{{apply_auto('CSSPropertyWebkitColumnGap', auto_getter='hasNormalColumnGap',
auto_setter='setHasNormalColumnGap', auto_identity='CSSValueNormal')}}
+{{apply_auto('CSSPropertyWebkitColumnWidth')}}
 {{apply_auto('CSSPropertyWidows')}}
 {{apply_auto('CSSPropertyZIndex')}}

[andersr, 2014-08-18 11:53:12]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-08-18 11:53:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/462133002/40001

[commit-bot: I haz the power, 2014-08-18 12:55:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23215)

[commit-bot: I haz the power, 2014-08-18 14:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 14:06:00]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23227)

[andersr, 2014-08-18 14:31:05]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-08-18 14:31:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/462133002/40001

[commit-bot: I haz the power, 2014-08-18 15:16:02]

Committed patchset #3 (40001) as 180465